fix(demo): use relative asset paths - #136
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the blank GitHub Pages demo by generating relative asset URLs for the demo build.
The deployed
docs/index.htmlcurrently contains:Because this repository is published as a GitHub Pages project site under
/pdf-elements/, those absolute paths resolve against the organization site root:instead of:
This causes the JavaScript request to return HTML and be rejected due to its MIME type, while the CSS request returns 404.
Change
Set the Vite
baseto./only for--mode demobuilds.This makes the generated demo portable under the GitHub Pages project path without hard-coding
/pdf-elements/, and leaves the library build and local development behavior unchanged.