[stable33] fix(behat): stop nested develop/pdf fetches causing cURL 52 flakes - #8489
Merged
Merged
Conversation
Provide an inline data-URI from small_valid.pdf so scenarios can send PDFs without nested HTTP to the PHP built-in server. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
With fixtures no longer nesting HTTP to develop/pdf, a single-process php -S is enough and avoids experimental PHP_CLI_SERVER_WORKERS flakes. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
workers: 0 deadlocks any nested self-HTTP on php -S. Use the minimum of two workers while fixtures stay on inline PDF base64 to avoid the previous cURL 52 flakes from workers: 10. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Serve small_valid.pdf from a second local php -S process and add a
scenario that posts {"url":"<PDF_URL>"} so url download stays covered
without nested HTTP to the Behat Nextcloud server.
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Failsafe for residual cURL 52 empty-reply flakes during Behat HTTP bursts; retries up to three times with backoff and STDERR diagnostics. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Retrying around cURL 52/7 hides the real failure and is unsafe for POST requests such as request-signature. Prefer diagnosing PHP built-in server death via behat-builtin-extension verbose mode. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
chore(behat): bump nextcloud-behat to 1.6.1 for builtin 0.7.0 Unlock verbose PHP built-in server diagnostics so Behat CI can show PID, logs, and exit status on cURL 52 flakes. Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com> [skip ci]
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8430
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.