feat: centralize npm build workflow - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue #15 by replacing the deprecated Nextcloud
node.ymlpath with the currentnpm-build.ymlmodel.Nextcloud's current
node.ymlis intentionally a failing no-op that asks consumers to migrate tonpm-build.ymland is scheduled for removal at the end of 2026.This PR adds:
.github/workflows/npm-build.yml;workflow-templates/npm-build.ymlcaller;The caller is pinned to immutable commit
bab6f01a48474e6b00feb71882be2f4dafe928fc.LibreCode adaptations
Compared with the current Nextcloud
npm-build.yml:ubuntu-latest-lowwith publicubuntu-latest;engine-strict, avoiding installation of a PR-controlled npm range as a global package;npm execinstead of installing it globally;bash -c;nodeso existing branch protection checks keep matching.Consumer migration
For consumers such as
LibreCodeCoop/extract, the migration should rename the installed workflow fromnode.ymltonpm-build.yml, while the reusable implementation keeps the protected summary check namenode.