feat: centralize info.xml lint workflow - #22
Merged
Merged
Conversation
14 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Start #15 with
lint-info-xmlusing the adoption model from #16.Instead of copying the complete workflow into every consumer, this PR splits the concern into:
.github/workflows/lint-info-xml.yml;workflow-templates/lint-info-xml.ymlthat owns thepull_requestevent and calls the reusable implementation;Improvements over the upstream Nextcloud template
The reusable implementation keeps the useful behavior from Nextcloud while making several LibreCode adaptations:
ubuntu-latestinstead ofubuntu-latest-low;actions/checkoutv7.0.1 with persisted credentials disabled;appinfo/;c8fe8dcb388d2ed7b566e982fd64aa38463ba80ainstead of downloading from mutable
master;ChristophWurst/xmllint-actionpinned to a full commit SHA.Distribution model
The consumer-owned workflow stays intentionally small:
This preserves repository-level event ownership while keeping implementation centralized. The caller is pinned to the exact repository commit that introduced the reusable workflow; updates therefore remain reviewable through the catalog/consumer synchronization path instead of silently following a mutable branch.
After merge, the catalog publisher can publish the caller template and
LibreCodeCoop/extractcan be migrated from its current copied Nextcloud workflow to the thin caller.