fix: require first merged PR message variable - #178
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the organization
first-merged-pr-commentworkflow consume the repository Actions variableFIRST_MERGED_PR_MESSAGEdirectly.The previous template defined an
envfallback message inside the workflow. That contradicted the intended configuration model: repositories should own the complete message through an Actions variable, while the shared workflow/action only provides generic behavior and placeholders.After this change:
FIRST_MERGED_PR_MESSAGEis a required repository Actions variable;${{ vars.FIRST_MERGED_PR_MESSAGE }}directly to the action;Signed-off-by: Vitor Mattos vitor@php.rio