refactor: simplify nightly release notes workflow - #175
Merged
Merged
Conversation
Signed-off-by: Vitor Mattos <vitor@php.rio>
Signed-off-by: Vitor Mattos <vitor@php.rio>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the large inline Bash/JQ implementation in
workflow-templates/nightly-release.ymlwith the reusablerelease-notes-from-pull-requestsaction merged in #174.The workflow now only:
All pull-request association, branch preference, deduplication, commit fallback, Markdown sanitization and GitHub API handling live in the tested action.
Why
The previous workflow embedded business logic in YAML:
That made the template harder to review, reuse and test. The new design keeps workflow YAML focused on orchestration.
Validation
The nightly template tests now assert that:
db491a51227ff4fd76b35b7a24ab7718aab6cbee;The action itself has focused unit tests added in #174.
Signed-off-by: Vitor Mattos vitor@php.rio