Conversation
httpx raises an error when RAG_OPENAI_PROXY is a socks5:// or socks5h:// URL unless the optional socksio dependency is installed, forcing users to build a custom image just to add httpx[socks].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add httpx[socks] to support socks5:// proxies for RAG_OPENAI_PROXY
Description:
Problem
RAG_OPENAI_PROXYis passed straight through toOpenAIEmbeddingsasopenai_proxy, which httpx uses to build the OpenAI client's transport.httpx only supports
socks5:///socks5h://proxy URLs when the optionalsocksioextra is installed — without it, using a SOCKS proxy fails atruntime. Deployments that need a SOCKS proxy currently have to build a
custom derived image just to
pip install httpx[socks].Fix
Add
httpx[socks]torequirements.txtandrequirements.lite.txtsoSOCKS proxy support works out of the box, and document the supported
proxy schemes in the README.