Skip to content

fix: mirror backend capability checks in scope save guards #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isaacraja wants to merge 1 commit into from
Closed

fix: mirror backend capability checks in scope save guards #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 20 additions & 20 deletions src/server/scopes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,10 @@ import type * as t from '@/types';
import { isInterfacePermissionPath } from '@/utils/interfacePermissions';
import { stripSecretPreviewValues } from '@/utils';
import { BASE_CONFIG_PRINCIPAL_ID } from './constants';
import { requireAnyCapability } from './capabilities';
import {
requireAllSectionCapabilities,
requireAnyCapability,
} from './capabilities';
import { safeFieldPath } from './utils/validation';
import { apiFetch } from './utils/api';
import {
Expand Down Expand Up @@ -284,11 +287,10 @@ export const saveFieldProfileValueFn = createServerFn({ method: 'POST' })
}),
)
.handler(async ({ data }) => {
await requireAnyCapability([
SystemCapabilities.ASSIGN_CONFIGS,
SystemCapabilities.MANAGE_CONFIGS,
]);
if (isInterfacePermissionPath(data.fieldPath)) return { success: true };
// Mirrors the backend field-PATCH check: broad manage:configs or the
// section-scoped manage:configs:<section> (assign caps do not gate fields).
await requireAllSectionCapabilities([data.fieldPath.split('.')[0]]);
const apiType = data.principalType;
const entries = await mergeIndexedArrayEntriesForScope(apiType, data.principalId, [
{ fieldPath: data.fieldPath, value: data.value },
Expand Down Expand Up @@ -338,12 +340,11 @@ export const bulkSaveProfileValuesFn = createServerFn({ method: 'POST' })
entries: Array<{ fieldPath: string; value: unknown }>;
};
}) => {
await requireAnyCapability([
SystemCapabilities.ASSIGN_CONFIGS,
SystemCapabilities.MANAGE_CONFIGS,
]);
const filtered = data.entries.filter((e) => !isInterfacePermissionPath(e.fieldPath));
if (filtered.length === 0) return { success: true, count: 0 };
await requireAllSectionCapabilities([
...new Set(filtered.map((e) => e.fieldPath.split('.')[0])),
]);
const apiType = data.principalType;
const entries = await mergeIndexedArrayEntriesForScope(apiType, data.principalId, filtered);
const response = await apiFetch(
Expand Down Expand Up @@ -396,9 +397,12 @@ export const createScopeFn = createServerFn({ method: 'POST' })
principalId?: string;
};
}) => {
// Mirrors the backend upsert check: broad manage, broad assign, or
// target-scoped assign:configs:<principalType>.
await requireAnyCapability([
SystemCapabilities.ASSIGN_CONFIGS,
SystemCapabilities.MANAGE_CONFIGS,
SystemCapabilities.ASSIGN_CONFIGS,
`assign:configs:${data.principalType}`,
]);
const principalId =
data.principalId ??
Expand Down Expand Up @@ -464,10 +468,7 @@ export const removeFieldProfileValueFn = createServerFn({ method: 'POST' })
};
}) => {
if (isInterfacePermissionPath(data.fieldPath)) return { success: true };
await requireAnyCapability([
SystemCapabilities.ASSIGN_CONFIGS,
SystemCapabilities.MANAGE_CONFIGS,
]);
await requireAllSectionCapabilities([data.fieldPath.split('.')[0]]);
const apiType = data.principalType;
const response = await apiFetch(
`/api/admin/config/${apiType}/${encodeURIComponent(data.principalId)}/fields?fieldPath=${encodeURIComponent(data.fieldPath)}`,
Expand Down Expand Up @@ -506,10 +507,7 @@ export const tombstoneFieldProfileValueFn = createServerFn({ method: 'POST' })
};
}) => {
if (isInterfacePermissionPath(data.fieldPath)) return { success: true };
await requireAnyCapability([
SystemCapabilities.ASSIGN_CONFIGS,
SystemCapabilities.MANAGE_CONFIGS,
]);
await requireAllSectionCapabilities([data.fieldPath.split('.')[0]]);
const apiType = data.principalType;
const response = await apiFetch(
`/api/admin/config/${apiType}/${encodeURIComponent(data.principalId)}/fields/tombstone`,
Expand Down Expand Up @@ -551,8 +549,9 @@ export const toggleScopeActiveFn = createServerFn({ method: 'POST' })
};
}) => {
await requireAnyCapability([
SystemCapabilities.ASSIGN_CONFIGS,
SystemCapabilities.MANAGE_CONFIGS,
SystemCapabilities.ASSIGN_CONFIGS,
`assign:configs:${data.principalType}`,
]);
const apiType = data.principalType;
const response = await apiFetch(
Expand Down Expand Up @@ -593,8 +592,9 @@ export const deleteScopeFn = createServerFn({ method: 'POST' })
};
}) => {
await requireAnyCapability([
SystemCapabilities.ASSIGN_CONFIGS,
SystemCapabilities.MANAGE_CONFIGS,
SystemCapabilities.ASSIGN_CONFIGS,
`assign:configs:${data.principalType}`,
]);
const apiType = data.principalType;
const response = await apiFetch(
Expand Down