Fix Svacer iterator leak warning#725
Open
marcofortina wants to merge 1 commit into
Open
Conversation
0f9e166 to
b876ba9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the real client iterator leak reported by Svacer in the ExtendedDesktopSize success path and tightens cursor cleanup so lazily generated cursor buffers are released for both owned and non-owned cursor objects.
Details
This addresses the Svacer reports for cursor.c by making the cached buffers have explicit cleanup paths, including the default static cursor case.
Validation
Configured, built, and ran the test suite locally with:
cmake -S . -B build \ -DCMAKE_BUILD_TYPE=Debug \ -DWITH_TESTS=ON \ -DWITH_EXAMPLES=OFF \ -DWITH_GTK=OFF \ -DWITH_SDL=OFF \ -DWITH_QT=OFF \ -DWITH_FFMPEG=OFF cmake --build build --parallel ctest --test-dir build --output-on-failureResult: 5/5 tests passed.
Closes #724