Repository navigation
feat(dispatch-helm): leave components mapped to null out of the chart update - #951
Open
guimoreirar wants to merge 1 commit into
Open
guimoreirar wants to merge 1 commit into
guimoreirar wants to merge 1 commit into
Conversation
… update An extra_builds image the chart does not deploy (a test mock, for example) had no way out of the central Helm dispatch: unmapped components fall back to their own name as the values key, so helm-update-chart wrote <component>.image.tag at the root of values.yaml, where nothing reads it (seen in LerianStudio/helm#2554 with plugin-br-bank-transfer-mock-jd). A component mapped to null in values_key_mappings / helm_values_key_mappings is now skipped. Unmapped components keep the old fallback, so existing callers are unaffected. Docs also note that nested keys (app.migrations) are allowed.
Contributor
🔍 PR Validation Summary✅ PR Mergeable — no blocking failures
|
Contributor
🛡️ CodeQL Analysis ResultsLanguages analyzed: ✅ No security issues found. 🔍 View full scan logs | 🛡️ Security tab |
Contributor
|
@coderabbitai review |
Contributor
🔍 Lint Analysis
|
✅ Action performedReview finished.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
dispatch-helmnow leaves a component out of the chart update when it is mapped tonullinvalues_key_mappings(helm_values_key_mappingsingo-release).Unmapped components keep the existing fallback (their own name as the values key), so current callers are unaffected.
Why
extra_buildsimages always join the central Helm dispatch (enable_helm_dispatchper group only decides whether a group dispatches on its own). An image the chart does not deploy, such as a test mock, had no way out: it fell back to its name andhelm-update-chartwrote<component>.image.tagat the root ofvalues.yaml, where nothing reads it. Seen in LerianStudio/helm#2554 withplugin-br-bank-transfer-mock-jd(fixed by hand there).Changes
.github/workflows/dispatch-helm.yml: skip a component whose mapping is explicitlynull; input description updated.docs/dispatch-helm.md,docs/go-release.md: documentnulland that nested keys (app.migrations) are allowed.Testing
actionlintand YAML parse pass. The skip predicate was exercised against: a mapping withnull(only that component skipped), withoutnull, empty, and a non-object value (nothing skipped). The skip happens before the payload append, so the JSON array stays well-formed.First consumer: LerianStudio/plugin-br-bank-transfer (maps its mock-jd image to
null).🤖 Generated with Claude Code