Repository navigation
fix(helm-upgrade-doc): wrap generated guides in a hidden Liquid raw block - #948
Merged
Merged
Conversation
…lock
charts.lerian.studio is built by GitHub Pages (Jekyll 3.10), which runs Liquid
over every .md. Upgrade guides carry Helm template snippets ({{ ... }}): they
raised hundreds of Liquid warnings and an unterminated one broke the whole
site build (LerianStudio/helm#2565 fixes the existing guides).
Generated guides that contain {{ or {% are now wrapped in
<!-- {% raw %} --> ... <!-- {% endraw %} -->: Liquid honours the tags and
GitHub's markdown view hides the comments. Raw markers are stripped from the
few-shot examples and from the model output first, so the model never echoes
them and the wrap is never nested (nested raw breaks Liquid too).
|
Warning Review limit reachedThe included review limit has been reached and this organization has disabled usage-based review continuation. Wait for reviews to reset or ask a billing admin to change After included review limits.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Next included review available in 7 minutes. View limit details
Comment |
Contributor
🔍 Lint Analysis
|
lerian-studio
added
size/XS
Contributor
🔍 PR Validation Summary✅ PR Mergeable — no blocking failures
|
This comment has been minimized.
This comment has been minimized.
lerian-studio
added
the
review-ready
This comment has been minimized.
This comment has been minimized.
bedatty
approved these changes
Oct 20, 2026
Contributor
|
@coderabbitai review |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
helm-upgrade-docnow writes generated upgrade guides that contain Helm template snippets ({{/{%) wrapped in a Liquid raw block hidden in HTML comments:Raw markers are stripped from the few-shot examples and from the model output before wrapping, so the model never echoes them and the wrap is never nested.
Why
charts.lerian.studio is built by GitHub Pages (Jekyll 3.10), which runs Liquid over every
.md. Upgrade guides carry Helm snippets: they raised hundreds of Liquid warnings, and an unterminated{{in one guide broke the whole site build. LerianStudio/helm#2565 fixes the existing guides; this keeps new ones from re-breaking it.{% raw %}inside an HTML comment; GitHub's markdown view hides the comment, so guides read the same on github.com.Testing
bash -nand shellcheck pass. The guard was exercised on four cases: guide with Helm snippets (wrapped once), model output that copied the markers (stripped, wrapped once), guide without templates (unchanged), example doc with markers (stripped before reaching the prompt).🤖 Generated with Claude Code