Repository navigation
Conversation
The subject looks ordinary on purpose. The break is declared below, in the form the release parser also treats as breaking — never exercised live until now. BREAKING CHANGE: the fixture asserts the footer form is detected too.
Contributor
|
Note ✅ Breaking change approvedApproved by @guimoreirar. 💥 The next release will be a major version. Gated by |
Contributor
🔍 PR Validation Summary✅ PR Mergeable — no blocking failures
|
Contributor
🔍 Lint Analysis
|
Contributor
|
@coderabbitai review |
✅ Action performedReview finished.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Final validation fixture 2 of 3 — breaking change declared with a
BREAKING CHANGE:footer, with an ordinary-looking subject.This form has never been exercised live. Every run so far used the
!subject, so the footer path of the detector has only ever been covered by unit tests.Not meant to be merged.
Expected: identical treatment to the bang form — the detector accepts both.
Type of Change
test: Adding or updating testsBreaking Changes
None — the footer is the fixture. Closed, never merged.
Testing
@this-branchor the beta tagDetector confirmed locally before pushing:
has-breaking-changes=true.Breaking change acknowledged: I understand that this PR intentionally introduces a breaking change and requires the next release to be a major version.
Related Issues