Skip to content

test(pr-validation): fixture 2 of 3 — break declared in a footer - #923

Open
bedatty wants to merge 1 commit into
developfrom
test/final-footer
Open

bedatty wants to merge 1 commit into
developfrom
test/final-footer

Conversation

@bedatty

@bedatty bedatty commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Description

Final validation fixture 2 of 3 — breaking change declared with a BREAKING CHANGE: footer, with an ordinary-looking subject.

This form has never been exercised live. Every run so far used the ! subject, so the footer path of the detector has only ever been covered by unit tests.

Not meant to be merged.

Expected: identical treatment to the bang form — the detector accepts both.

Type of Change

  • test: Adding or updating tests

Breaking Changes

None — the footer is the fixture. Closed, never merged.

Testing

  • YAML syntax validated locally
  • Triggered a real workflow run on a caller repository using @this-branch or the beta tag
  • Confirmed no secrets or tokens are printed in logs
  • Checked that unrelated workflows are not affected

Detector confirmed locally before pushing: has-breaking-changes=true.

Breaking change acknowledged: I understand that this PR intentionally introduces a breaking change and requires the next release to be a major version.

Related Issues

The subject looks ordinary on purpose. The break is declared below, in
the form the release parser also treats as breaking — never exercised
live until now.

BREAKING CHANGE: the fixture asserts the footer form is detected too.
@bedatty
bedatty requested a review from a team as a code owner October 16, 2026 21:39
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: LerianStudio/github-actions-shared-workflows/.coderabbit.yml
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: 29cfed11-4db1-41ca-ab94-20f46f9cead2
📥 Commits

Reviewing files that changed from the base of the PR and between 5b12fbd and 624f37d.

📒 Files selected for processing: 1
  • docs/.fixtures/final-footer.md

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The documentation fixture now states that a footer, not a bang, declares a breaking change.

Changes

Fixture wording

Layer / File(s) Summary
Breaking-change declaration wording
docs/.fixtures/final-footer.md
The fixture identifies a footer instead of a bang as the breaking-change declaration.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 624f3

The described change is a temporary fixture for footer detection, with no demonstrated user-facing failure or other actionable risk. The PR description says it is intended to close without merging.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies a test fixture for PR validation and specifies that the breaking change is declared in a footer.
Description check Passed The description covers the change, change type, testing, intentional temporary scope, and expected detector behavior. The Breaking Changes section explains that the fixture is not a caller-facing chan…
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description covers the change, change type, testing, intentional temporary scope, and expected detector behavior. The Breaking Changes section explains that the fixture is not a caller-facing change. The caller workflow link and related issue reference are missing, but these omissions are non-critical.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@lerian-studio

lerian-studio commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Note

✅ Breaking change approved

Approved by @guimoreirar. 💥 The next release will be a major version.

Gated by rule develop <- '*' · How this gate works

@lerian-studio lerian-studio added breaking-change Callers must update their workflow configuration after this change size/XS PR changes < 50 lines awaiting-breaking-approval A breaking change on this PR is waiting on a human decision documentation Improvements or additions to documentation and removed awaiting-breaking-approval A breaking change on this PR is waiting on a human decision labels Oct 16, 2026
@bedatty
bedatty deployed to breaking-approval October 16, 2026 21:40 — with GitHub Actions Active
@lerian-studio

Copy link
Copy Markdown
Contributor

🔍 PR Validation Summary

✅ PR Mergeable — no blocking failures

Check Status Blocking
Source Branch ✅ success yes
PR Title ✅ success yes
PR Description ✅ success yes
Breaking Change Guard ✅ success yes
Commit Signatures ✅ success yes
PR Size ✅ success no
Auto Labels ✅ success no
PR Metadata ✅ success no

🔍 View workflow run

@lerian-studio

Copy link
Copy Markdown
Contributor

🔍 Lint Analysis

Check Files Scanned Status
YAML Lint no changes ⏭️ skipped
Action Lint no changes ⏭️ skipped
Pinned Actions no changes ⏭️ skipped
Markdown Link Check 1 file(s) ✅ success
Spelling Check 1 file(s) ✅ success
Shell Check no changes ⏭️ skipped
README Check no changes ⏭️ skipped
Composite Schema no changes ⏭️ skipped
Deployment Matrix no changes ⏭️ skipped

🔍 View full scan logs

@lerian-studio

Copy link
Copy Markdown
Contributor

@coderabbitai review

@lerian-studio lerian-studio added the review-ready Required checks passed — CodeRabbit is cleared to review label Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

This branch was successfully deployed

1 active deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Callers must update their workflow configuration after this change documentation Improvements or additions to documentation review-ready Required checks passed — CodeRabbit is cleared to review size/XS PR changes < 50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants