Repository navigation
build: publish tclient releases and remove duplicate example - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the duplicate example client now that
cmd/tclientis the supported entry point, and add a complete GitHub Release pipeline for distributing versioned CLI binaries alongside the Go library.Changes
_example/telnet_client, including its nested module files and CI step. Keep the independent TCP monitor example and document migration tocmd/tclient.tclient --versionwith release version, full commit, build date, Go compiler, and target platform. It works without a host or stdin; ordinary Go builds/installations use embedded module/VCS metadata where available.Releaseworkflow with a version input. Manual releases are restricted to master and create an annotated tag for the exact tested commit; existing tags must match that commit.WindowChange(height, width)argument order, Go 1.20 minimum, prompt/line-ending changes, IAC escaping, and removed APIs. Link the guide from the Release body and include it with the complete documentation in every archive.Validation
Local validation passed:
go test -race -timeout=3m ./...,go vet ./..., the monitor example, all 20 Linux PTY/TCP scenarios, and linked--version/--helpsmoke tests. Independent review also checked workflow YAML, shell syntax, tag validation, fixed-commit handling, and draft/attestation/publication order.All five CI jobs passed for the latest commit
8c7c3e78907ab64a33f34c775783f641c317c7c9: Linux/Windows × Go 1.20.x/stable plus the release snapshot job. GoReleaser v2.19.0 configuration validation, all six archives (including the changelog and full documentation), every SHA-256 digest, and the extracted Linux CLI smoke tests passed. The run includes the downloadable snapshot artifact (seven-day retention).Independent review checked the migration notes against
v0.0.2and current source, including the silentWindowChangeargument-order change. YAML validation and local document-link checks also passed.Copilot review was requested, but GitHub reported insufficient review quota on both attempts; it did not produce a code review or any inline findings. Independent code/workflow review completed with no blocking findings.
Windows binaries support redirected sessions; interactive TTY support remains Unix-only. The Go library and CLI share one semantic-version tag.