Fix bugs and refactor entity architecture#996
Merged
Merged
Conversation
Major improvements across the library: - Refactored entity classes: introduced TermsEntity base class to share labels/descriptions/aliases handling across Item, Property, and MediaInfo, eliminating code duplication. - Fixed multiple data type bugs: Time parsing now handles years >4 digits; GlobeCoordinate equality no longer mutates values; Snak/Reference equality comparisons properly typed. - Improved API robustness: added TIMEOUT config support to prevent indefinite hangs; fixed SPARQL query to send in request body (not URL); changed max_retries default from 1000 to 100. - Fixed error handling: introduced AnonymousEditNotAllowedError for clearer failures; improved login error messages. - Added new methods: count() on Claims/Qualifiers to distinguish between distinct properties and total items; lexeme_edit_sense helper. - Fixed integration tests: corrected fixture scope to session-level; updated exception types; fixed docker-compose volume persistence; added PowerShell instructions. - Fixed API parameter issues: lexeme_edit_sense now uses correct senseId; search_entities properly truncates results and handles strict_language; edit_entity validates type parameter. - Fixed fastrun caching: replaced lru_cache with per-instance prop_dt_map to avoid stale cache across containers. - Fixed edge cases: LanguageValue handles None values; Form.grammatical_features setter validates types and replaces instead of accumulating; Claims comparison with unrelated types returns False.
This was referenced Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major improvements across the library: