Skip to content

ci: add Node version matrix and expand target coverage#9

Closed
antonymarion wants to merge 1 commit intoLadybugDB:mainfrom
antonymarion:ci/node-matrix-and-target-coverage
Closed

ci: add Node version matrix and expand target coverage#9
antonymarion wants to merge 1 commit intoLadybugDB:mainfrom
antonymarion:ci/node-matrix-and-target-coverage

Conversation

@antonymarion
Copy link
Copy Markdown

Summary

  • add an explicit Node.js CI matrix for supported runtime versions (18, 20, 22)
  • add actions/setup-node so CI no longer depends on runner-default Node versions
  • expand build target coverage by adding macos-13 (darwin-x64) to match packaged binary targets
  • add a non-blocking Node 24 canary job to surface upcoming runtime breakage early

Why

Recent Node runtime issues can slip through when CI does not pin/test multiple Node versions. This change makes runtime coverage explicit and improves confidence for ABI/runtime compatibility checks.

Test plan

  • workflow syntax validates in CI
  • matrix now runs across Node 18/20/22 on all configured OS/arch targets
  • canary job runs on Node 24 without blocking merges

Add explicit Node 18/20/22 coverage to CI, add macOS x64 to match packaged targets, and include a non-blocking Node 24 canary job to catch upcoming runtime regressions early.

Made-with: Cursor
@antonymarion antonymarion marked this pull request as draft April 16, 2026 08:37
Copy link
Copy Markdown
Contributor

@adsharma adsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. We certainly want to expand the supported node version matrix, but do it in the right place while optimizing the CI cost/latency.

You could argue that this repo is the right place to build packages (and I agree), but it takes some work to make the move.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
@antonymarion
Copy link
Copy Markdown
Author

Thank you for working on this. We certainly want to expand the supported node version matrix, but do it in the right place while optimizing the CI cost/latency.

You could argue that this repo is the right place to build packages (and I agree), but it takes some work to make the move.

Yep did not check that the original ladybug repo (not the nodejs one) has the logic for build and deploy for extending the matrix compliance with several versions too.

thks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants