Conversation
When using a prebuilt liblbug archive, derive the native addon extra link libraries from Ladybug's generated link lines even when those lines do not contain the archive itself. This keeps third-party static libraries such as Thrift on the lbugjs.node link line and avoids unresolved symbols when the addon is loaded.
Convert Ladybug JSON values through Value::toString() instead of Value::getValue<std::string>(). JSON uses string-like storage but the std::string getter asserts that the logical type is STRING, BLOB, or UUID, so debug/assert-enabled builds failed while release builds could appear to work by reading the underlying string value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: a commit landed on main repo that broke the extension ABI by adding an extra bool on DBConfig.