Closed
Conversation
adsharma
force-pushed
the
repro-windows-db-path-getcwd
branch
from
3a78d6a to
23f1ad3
Compare
adsharma
force-pushed
the
repro-windows-db-path-getcwd
branch
from
23f1ad3 to
2486c57
Compare
Contributor
Author
|
The issue exists only in a electron + wasm env. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: LadybugDB/ladybug#383
Reproduce the reported regression on CI.
Suspected cause:
The core fix should be in
StorageUtils::expandPath: avoidstd::filesystem::absolute()for already-absolute paths, and ideally detect Windows drive/UNC paths before calling anything that needs cwd.