Keep query results alive through connection ownership#12
Merged
Conversation
adsharma
force-pushed
the
nodejs_conn_ownership
branch
from
a498eea to
2dee976
Compare
adsharma
force-pushed
the
nodejs_conn_ownership
branch
from
10bb41d to
febe857
Compare
NodeQueryResult now retains the native Connection instead of a Database handle. The result objects depend on database-owned state, and the native connection is the stable owner of that state even after the JS connection wrapper is closed. This fixes the case where async query results are discarded and later finalized after conn.closeSync() and db.closeSync(). The finalizer can still destroy the MaterializedQueryResult safely because the retained connection keeps the backing database state alive. Also add a regression test that mirrors the file-backed async query sequence from the external crash reproducer.
adsharma
force-pushed
the
nodejs_conn_ownership
branch
from
48facbc to
b8f0a3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8
NodeQueryResult now retains the native Connection instead of a Database handle. The result objects depend on database-owned state, and the native connection is the stable owner of that state even after the JS connection wrapper is closed.
This fixes the case where async query results are discarded and later finalized after conn.closeSync() and db.closeSync(). The finalizer can still destroy the MaterializedQueryResult safely because the retained connection keeps the backing database state alive.
Also add a regression test that mirrors the file-backed async query sequence from the external crash reproducer.