fix(fts): synchronize wildcard DF accumulation#1
Open
future3OOO wants to merge 1 commit intoLadybugDB:mainfrom
Open
fix(fts): synchronize wildcard DF accumulation#1future3OOO wants to merge 1 commit intoLadybugDB:mainfrom
future3OOO wants to merge 1 commit intoLadybugDB:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MatchTermsVertexComputecopy()worker instancesunordered_mapwrite race in the wildcard FTS pathRoot cause
MatchTermsVertexComputestoresstd::unordered_map<offset_t, uint64_t>& resDfsandcopy()returns new worker instances that share that same map. Ladybug runs those copies concurrently fromVertexComputeTask::run(), so wildcard matches can executeresDfs[nodeIds[i].offset] = dfs[i];from multiple worker threads at once.Why this fix
This is the smallest correctness-first change that matches the demonstrated race without changing the existing
VertexComputeAPI. A thread-local merge design may recover more parallelism later, but it needs extra merge plumbing that does not exist on the current worker interface.Validation
main(160c616cdb0688fd00fdcb4686bb269801a374d4)augmentcalls with native frames throughMatchTermsVertexCompute,VertexComputeTask::run(), andstd::__detail::_Map_base<...>::operator[]gcc/g++/clangabsent), so I could not rebuild the extension locally before opening this draft PRFollow-up
If maintainers want the higher-throughput design, I can rework this toward worker-local accumulation plus post-scan merge once the merge point is agreed.