Skip to content

add npm-audit-fix workflow#12

Closed
aheev wants to merge 1 commit intoLadybugDB:masterfrom
aheev:add-vuln-workflow
Closed

add npm-audit-fix workflow#12
aheev wants to merge 1 commit intoLadybugDB:masterfrom
aheev:add-vuln-workflow

Conversation

@aheev
Copy link
Copy Markdown

@aheev aheev commented Apr 25, 2026

  • Runs every monday
  • raise a PR only if there are >= high vulnerabilities

@aheev
Copy link
Copy Markdown
Author

aheev commented Apr 25, 2026

@adsharma could you PTAL?

@adsharma
Copy link
Copy Markdown
Contributor

https://github.com/ybiquitous/npm-audit-fix-action is another possibility. Search tells me they're popular, around for many years. But another dependency.

Have you looked into why this is significant enough to have a dedicated action in the marketplace?

@aheev
Copy link
Copy Markdown
Author

aheev commented Apr 26, 2026

https://github.com/ybiquitous/npm-audit-fix-action is another possibility. Search tells me they're popular, around for many years. But another dependency.

Have you looked into why this is significant enough to have a dedicated action in the marketplace?

I have encountered these actions initially, but lost during revisions. Curious, why can't we use Dependabot for the same?

If we want more fine-grained control, we can use renovate too

@adsharma
Copy link
Copy Markdown
Contributor

Agree - dependabot is a better option because it leaves a PR based audit trail. The other actions on marketplace are there for further automation and less PR noise (there is a lot of it in the nodejs world).

@aheev
Copy link
Copy Markdown
Author

aheev commented Apr 26, 2026

Agree - dependabot is a better option because it leaves a PR based audit trail. The other actions on marketplace are there for further automation and less PR noise (there is a lot of it in the nodejs world).

is the dependabot auto fix enabled already?

@adsharma
Copy link
Copy Markdown
Contributor

I toggled these two:

  • Dependabot security updates
  • Grouped security updates

from disabled -> enabled.

Let's give it a day or two to test and then close this PR?

@aheev
Copy link
Copy Markdown
Author

aheev commented Apr 26, 2026

I toggled these two:

  • Dependabot security updates
  • Grouped security updates

from disabled -> enabled.

Let's give it a day or two to test and then close this PR?

LGTM

@aheev
Copy link
Copy Markdown
Author

aheev commented Apr 26, 2026

Also I am enabling

I toggled these two:

  • Dependabot security updates
  • Grouped security updates

from disabled -> enabled.

Let's give it a day or two to test and then close this PR?

should I apply the same on api-server repo?

@adsharma
Copy link
Copy Markdown
Contributor

api-server also has the same settings now.

@adsharma adsharma closed this Apr 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants