Repository navigation
Fix the linter workflow for newer ruff version - #10
Conversation
Pin ruff at the current version so it doesn't break in the future, and fix various linter errors with this version. Target python 3.9 to match the main Ladybird repo, as this is still the default macOS version.
Walkthrough
Priority: Merge Risk:
|
There was a problem hiding this comment.
Actionable comments posted: 1

Review info
-
Run configuration-
- Source mode: Auto
- Repository: Unavailable
- Branch: Unavailable
- File: No configuration file from this repository applied
- Commit: Unavailable
- Layers: Organization UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
2d9a5c4a-f774-40ee-bd83-55c0d3f41c1a
Files selected for processing: 4-
.github/workflows/lint.ymlmain.pypyproject.tomlrun_all_and_update_results.py
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
-
| with: | ||
| version: "0.17.2" |
There was a problem hiding this comment.
Restrict the workflow token permissions.
This job only checks out the repository and runs Ruff. Add an explicit read-only permission scope instead of inheriting repository defaults.
Proposed permission scope
-
jobs: lint: + permissions: + contents: read
🧰 Tools
-
🪛 zizmor (1.30.1)
-
[warning] 6-16: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block
(excessive-permissions)
-
Source: Linters/SAST tools
Pin ruff at the current version so it doesn't break in the future, and fix various linter errors with this version. Target python 3.9 to match the main Ladybird repo, as this is still the default macOS version.