Skip to content

Fix the linter workflow for newer ruff version - #10

Merged
trflynn89 merged 1 commit into
LadybirdBrowser:masterfrom
trflynn89:lint
Oct 26, 2026
Merged

trflynn89 merged 1 commit into
LadybirdBrowser:masterfrom
trflynn89:lint

Conversation

@trflynn89

Copy link
Copy Markdown
Contributor

Pin ruff at the current version so it doesn't break in the future, and fix various linter errors with this version. Target python 3.9 to match the main Ladybird repo, as this is still the default macOS version.

Pin ruff at the current version so it doesn't break in the future, and
fix various linter errors with this version. Target python 3.9 to match
the main Ladybird repo, as this is still the default macOS version.
@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Walkthrough

The changes pin Ruff to version 0.17.2 and configure Ruff and Pyright for Python 3.9. They update Python imports and annotations. In the runner, subprocess output capture uses capture_output=True, and several test-result errors now raise RuntimeError. A separate subprocess call explicitly sets check=False, which matches its previous default.

Priority: Low

Merge Risk: Minimal · up to fe8f6

The changes pin Ruff and update Python 3.9 tooling compatibility without introducing a material merge-blocking risk.

Pre-merge checks: Passed 3
Check name Status Explanation
Description check Passed The description directly matches the changes. It covers Ruff pinning, linter fixes, and Python 3.9 targeting.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


Review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2d9a5c4a-f774-40ee-bd83-55c0d3f41c1a
Commits

Reviewing files that changed from the base of the PR and between 3586455 and fe8f644.

Files selected for processing: 4
  • .github/workflows/lint.yml
  • main.py
  • pyproject.toml
  • run_all_and_update_results.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment on lines +11 to +12
with:
version: "0.17.2"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor · Security & Privacy · Quick win

Restrict the workflow token permissions.

This job only checks out the repository and runs Ruff. Add an explicit read-only permission scope instead of inheriting repository defaults.

Proposed permission scope
 jobs:
   lint:
+    permissions:
+      contents: read
🧰 Tools
🪛 zizmor (1.30.1)

[warning] 6-16: overly broad permissions (excessive-permissions): default permissions used due to no permissions: block

(excessive-permissions)

Source: Linters/SAST tools

@trflynn89
trflynn89 merged commit 0090e44 into LadybirdBrowser:master Oct 26, 2026
2 checks passed
@trflynn89
trflynn89 deleted the lint branch October 26, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant