Fix/dashboard form accessibility#985
Open
Benedict315 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary: Adds proper id attributes to all form inputs and htmlFor attributes to labels in the dashboard settings tab's stream-creation form for proper accessibility association.
Changes:
Added id attributes to all inputs, textarea, and select elements in the stream form
Added htmlFor attributes to all labels to programmatically associate them with their controls
Added a visually-hidden label for the template name input (previously only had aria-label)
Used consistent wrapping label pattern throughout the form
Files modified:
dashboard-view.tsx (lines 887, 922, 931-943)
Accessibility improvements:
Screen readers can now properly announce field labels
Controls can be targeted by tests and anchor links via their ids
Maintains existing visual appearance (no visual changes)
closes #632