Add test for update_fee_config NotInitialized path#984
Open
Benedict315 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary: Adds a test to cover the previously untested NotInitialized error path in the update_fee_config function.
Changes:
Added test_update_fee_config_rejects_not_initialized test in test.rs
The test calls try_update_fee_config before initialize and asserts that it returns Err(Ok(StreamError::NotInitialized))
Context: The update_fee_config function calls load_config(&env) at line 90 in lib.rs, which returns StreamError::NotInitialized when called before initialize. While this error path was already tested once via transfer_admin, there was no specific test calling update_fee_config on an uninitialized contract.
Testing:
Test passes: test_update_fee_config_rejects_not_initialized ... ok
closes #792