Skip to content

Disable dropped-audio submit check by default #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfwolffe merged 1 commit into from
Apr 10, 2026
Merged

Disable dropped-audio submit check by default #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions components/recorder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,12 @@ const createSilentAudio = () => {

const scratchURL = createSilentAudio();

export default function RecorderRefactored({ submit, accompaniment, logOperation = null }) {
export default function RecorderRefactored({
submit,
accompaniment,
logOperation = null,
enableDroppedAudioDetection = false,
}) {
const dispatch = useDispatch();
const router = useRouter();
const { slug, piece, actCategory, partType } = router.query;
Expand Down Expand Up @@ -535,7 +540,9 @@ export default function RecorderRefactored({ submit, accompaniment, logOperation
}

try {
if (!ignoreSilence && ffmpegLoaded) {
// Keep dropped-audio detection available as an opt-in tool without
// blocking the default student submit flow.
if (enableDroppedAudioDetection && !ignoreSilence && ffmpegLoaded) {
const silenceResult = await catchSilence(
ffmpegRef,
url,
Expand Down Expand Up @@ -593,6 +600,7 @@ export default function RecorderRefactored({ submit, accompaniment, logOperation
}
},
[
enableDroppedAudioDetection,
ignoreSilence,
ffmpegLoaded,
ffmpegRef,
Expand Down Expand Up @@ -726,7 +734,7 @@ export default function RecorderRefactored({ submit, accompaniment, logOperation
</Col>
</Row>
<AudioDropModal
show={showAudioDrop}
show={enableDroppedAudioDetection && showAudioDrop}
silenceData={silenceData}
onIgnore={() => {
setIgnoreSilence(true);
Expand Down
Loading