fix: correct values and references for CFHTLS, COSMOS, LSST, DES, HSC, Euclid - #135
Merged
Merged
Conversation
…nd psf_fwhm values - effective_wavelength i: 716.766 -> 761.766 (digit transposition) - zeropoint z: 25.05 -> 25.02 (align with CFHT Megacam page) - psf_fwhm: replace figure-derived values with T0007 Table 4 band means u 0.81->0.85, g 0.84->0.78, r 0.73->0.71, i 0.66->0.64, z 0.66->0.68
- sky_brightness: add GalSim docs as reference (was empty, violating AGENTS.md) - gain: refine comment to note observations obtained with gain of 1 (confirmed from Koekemoer 2007, section 2.1)
… URL - zeropoints: u/g/r/i/z/y updated to match speclite lsst2016 computation (all were ~0.03-0.04 mag lower than current speclite output) - gain reference: replace broken imSim stamp.py#L416 URL with readout.py (gain is now per-amplifier from camera model; 1.0 is the e-image convention)
- zeropoint_airmass: keep 1.3 (confirmed correct per speclite decam2014 convention), add explanatory comment referencing Ting Li's airmass
… reference - Euclid VIS zeropoint: 25.91 -> 25.92 (speclite rounding) - HSC y-band zeropoint: 27.33 -> 27.34 (speclite rounding) - HSC sky_brightness: replace dead Suprime-Cam URL with Wayback Machine archive, add comment noting values are Suprime-Cam used as approximation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A batch of value and reference corrections/clarifications across 6 existing survey YAMLs, found during a verification pass against primary sources:
effective_wavelength(716.766 → 761.766, a digit transposition), z-bandzeropoint(25.05 → 25.02, aligned with the CFHT MegaCam page), and replace figure-derivedpsf_fwhmvalues with the T0007 paper's Table 4 band means (u/g/r/i/z all shift slightly).sky_brightnessreference (GalSim docs — was violatingAGENTS.md's "values without a source are not accepted"), and clarify thegaincomment to note observations were obtained with gain of 1 (Koekemoer 2007, §2.1).speclitelsst2016computation — they were all ~0.03–0.04 mag low — and fix a broken imSimgainreference URL (stamp.py#L416→readout.py, with an updated comment explaining the per-amplifier gain convention).zeropoint_airmasscomment (value of 1.3 confirmed correct per thedecam2014convention; comment now cites the reference airmass source).Test plan
pytest --cov— 36 passedpre-commit run --all-files— all hooks passpython -m surveycodexandsurveycodex --refsrun cleanlyscripts/check_zeropoints.pyandscripts/check_effective_wavelengths.py— LSST and HSC values now match speclite exactly (previously off by rounding/precision)🤖 Generated with Claude Code