fix: repair stale CI toolchain pins - #134
Merged
Merged
Conversation
CI on PR #133 exposed two pre-existing infra staleness issues, unrelated to that PR's content: - build (3.7): GitHub's ubuntu-latest runner image is now 24.04, which has no published Python 3.7 build (python-versions manifest only ships 3.7.17 for 20.04/22.04). Pin the job to ubuntu-22.04, which has builds for all of 3.7-3.12, restoring the full matrix. - pre-commit pyupgrade: v3.15.2 crashes with "TypeError: cannot use a bytes pattern on a string-like object" on Python 3.14 (what the hosted runner's pre-commit action now uses). Bump to v3.21.2, which added explicit --py314-plus support and fixes the incompatibility; --py37-plus still works so the lint target stays the same. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #133 surfaced two pre-existing CI infra issues, unrelated to that PR's content, that would block any PR from going green right now:
build (3.7)fails withVersion 3.7 with arch x64 not found. GitHub'subuntu-latestrunner image is now 24.04 ("noble"), which has no published Python 3.7 build — theactions/python-versionsmanifest only ships3.7.17for Ubuntu 20.04/22.04. Pinning the job toubuntu-22.04(still fully supported as a hosted runner) restores availability for the whole3.7–3.12matrix (verified against the manifest).pre-commit/pyupgradecrashes withTypeError: cannot use a bytes pattern on a string-like object— a known incompatibility betweenpyupgrade==3.15.2and Python 3.14 (what the hostedpre-commitaction now runs by default). Bumping tov3.21.2(latest, which added explicit--py314-plussupport) fixes it;--py37-plusis unchanged, so the lint target stays the same perpython_requires = >=3.7.No source files changed — this only touches CI/lint tooling pins.
Test plan
pre-commit run --all-filespasses locally withpyupgrade==3.21.2pytest --cov— 36 passedactions/python-versionsmanifest that Python 3.7.17–3.12.14 all have published builds forubuntu-22.04Python packageandCheck code styleCI checks go green on this PR🤖 Generated with Claude Code