fix(reinstall): remove redundant disk resize causing 500#144
Merged
Conversation
The reinstall pipeline ran import_template_disk (which already imports AND resizes the primary disk to the template size) followed by a separate resize_disk step. The second resize asks Proxmox to resize to the same size, which it rejects as a disallowed shrink, surfacing as a generic 500. Removes the redundant resize_disk step, restoring the original pre-pipeline reinstall behaviour. Fixes #142
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/v1/vm/{id}/re-installreturned500 InternalServerError.Root cause
The reinstall pipeline (introduced in "feat: pipeline reinstall") ran two disk steps:
import_template_disk— which already doesimport_disk+resize_main_disk, resizing the primary disk to the full template size.resize_diskstep — asking Proxmox to resize the disk to that same size.Proxmox only permits growing a disk; resizing to a size that isn't strictly larger is rejected as a disallowed shrink, which surfaces as a generic 500. The original pre-pipeline
reinstall_vmnever had this extra resize, so this was a regression.Fix
Removed the redundant
resize_diskstep. The pipeline is now: stop → unlink → import+resize → start, matching the original behaviour.Fixes #142