Skip to content

docs: fix update libstk0-dev to libstk-dev for debian/ubuntu#8409

Open
NewBieCoderXD wants to merge 3 commits into
LMMS:masterfrom
NewBieCoderXD:docs/libstk-dev
Open

docs: fix update libstk0-dev to libstk-dev for debian/ubuntu#8409
NewBieCoderXD wants to merge 3 commits into
LMMS:masterfrom
NewBieCoderXD:docs/libstk-dev

Conversation

@NewBieCoderXD
Copy link
Copy Markdown

Aimed at issue #8408

I have changes on wiki submodule, but it seems like github doesn't support PR for submodule

This PR specifies similar dependency of libstk0-dev
Feel free to close this PR if you think the change is trivial.

For wiki changes, see my commit.

@JohannesLorenz
Copy link
Copy Markdown
Contributor

Thank you for the suggestion!

However, I am not sure about how this improves it. Did the old message confuse you a lot? "Similar" usually means: It could be libstk0-dev, but also libstk1-dev or libstk-dev. With the suggested change, it means: libstk0-dev or libstk-dev (but not libstk1-dev).

Also, there are a lot of similar places, e.g. for portaudio.

@NewBieCoderXD
Copy link
Copy Markdown
Author

NewBieCoderXD commented May 26, 2026

Thank you for the suggestion!

However, I am not sure about how this improves it. Did the old message confuse you a lot? "Similar" usually means: It could be libstk0-dev, but also libstk1-dev or libstk-dev. With the suggested change, it means: libstk0-dev or libstk-dev (but not libstk1-dev).

Also, there are a lot of similar places, e.g. for portaudio.

Hey, thank you for your feedback.

You're right. I just realized this change makes it confusing. I'm sorry for the mistake.
How do you feel about changing it to "libstk-dev (or similar)"? (Remove the 0)

I totally understand if you think the change in this PR is very trivial and unnecessary. However, I strongly recommend updating wiki following this commit. (It's not in PR because I'm not sure how to open PR for submodule)

Edit: Oh, wait. You already updated the wiki. Thank you so much! This might be fastest PR ever. Feel free to close this PR if you think the change is unnecessary. :)

@JohannesLorenz
Copy link
Copy Markdown
Contributor

How do you feel about changing it to "libstk-dev (or similar)"? (Remove the 0)

What about "libstk-dev or libstk0-dev (or similar)" ?

I totally understand if you think the change in this PR is very trivial and unnecessary.

No worries.

However, I strongly recommend updating wiki following this commit. (It's not in PR because I'm not sure how to open PR for submodule)

Edit: Oh, wait. You already updated the wiki. Thank you so much! This might be fastest PR ever. Feel free to close this PR if you think the change is unnecessary. :)

Where do you see that the LMMS wiki has been updated? Can you give a link, please?

@NewBieCoderXD
Copy link
Copy Markdown
Author

NewBieCoderXD commented May 27, 2026

Where do you see that the LMMS wiki has been updated? Can you give a link, please?

I kinda messed up here. I cloned the project, and I didn't realized it came with an outdated version of wiki submodule since that's the wiki commit the latest main repo commit points to. The wiki has already been updated a year ago. I'm sorry for not checking it thoroughly. (I'm not quite familiar with git submodule)

Links: https://github.com/LMMS/lmms/wiki/dependencies-debian, https://github.com/LMMS/lmms/wiki/dependencies-ubuntu

What about "libstk-dev or libstk0-dev (or similar)" ?

Sounds nice! I'll update it right away

@JohannesLorenz
Copy link
Copy Markdown
Contributor

OK, I understand what you mean about the wiki. So, in other words, there is no need to update the wiki, correct?

However, the current state of the doc/wiki submodule is 2022. That also explains that you didn't see it. Maybe, do you want to include an update of it in this PR?

@NewBieCoderXD
Copy link
Copy Markdown
Author

OK, I understand what you mean about the wiki. So, in other words, there is no need to update the wiki, correct?

Correct.

However, the current state of the doc/wiki submodule is 2022. That also explains that you didn't see it. Maybe, do you want to include an update of it in this PR?

Yes please! I would greatly appreciate that.

@JohannesLorenz
Copy link
Copy Markdown
Contributor

You can do it in this PR - technically. I will ask some other LMMS devs if they are OK with it and will try to get back to you in the next days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants