Repository navigation
[Feature] pcp_shard_store: support async loading (each rank prefetches its own chunks) - #19
Open
ibrahimnd2000 wants to merge 2 commits into
Open
ibrahimnd2000 wants to merge 2 commits into
ibrahimnd2000 wants to merge 2 commits into
Conversation
This was referenced Nov 12, 2026
Ported from LMCache/LMCache#5545: the in-process engine moved to this repository in LMCache/LMCache#6254. Signed-off-by: Muhammad Ibrahim <ibrahimnd2000@gmail.com>
…s its own chunks) Follow-up to #5545 (sharded PCP store). **Depends on #5545**: this branch is built on it, so until #5545 merges the diff includes its commits. Only the top commit (`dbd78611`) is new. Ported from LMCache/LMCache#5553: the in-process engine moved to this repository in LMCache/LMCache#6254. Signed-off-by: Muhammad Ibrahim <ibrahimnd2000@gmail.com>
ibrahimnd2000
force-pushed
the
port/5553-pcp-shard-async
branch
from
November 19, 2026 07:07
664f740 to
1259f1c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Follow-up to #5545 (sharded PCP store). Depends on #5545: this branch is built on it, so until #5545 merges the diff includes its commits. Only the top commit (
dbd78611) is new.#5545 rejects
enable_async_loadingin shard mode. This adds it.chunk_index % world_size == rank). It passescum_chunk_lengths= "start of my k-th owned chunk" (+ the end of the last chunk), so the number the storage manager reports is the rank's sharded lookup answer, and the minimum is the same prefix as the synchronous path. A new helperpcp_shard.async_lookup_keysbuilds the keys and lengths.StorageManager.async_lookup_and_prefetchreported a hard-coded 0 when nothing hit. It now reportscum_chunk_lengths[0], which is 0 outside shard mode. In shard mode, that stops a rank whose first owned chunk misses from cutting the chunks before it._pcp_shard_retrievetakes this rank's chunks from its prefetch event (helperpcp_shard.select_prefetched), then runs the same exchange + per-chunk broadcast as the sync path. The event is popped, solookup_unpinhas nothing left to release. Used objects are unpinned and released as in the default async path; unused ones are released.Special notes for your reviewers:
Validated on a vLLM GLM-5.3 FP8 prefill engine (PCP8 + EP8, 8×B300) with a RESP (Valkey) remote tier, one instance per rank (#5548):
Tests (
tests/inprocess/v1/pcp_shard):LMCacheEngines:async_full(w2/4/8): whole prompt, byte-exact load, no pins or extra refs left.async_evict(w4/8): owner of chunk 5 lost it, so every rank agrees on 5 chunks.async_owner_miss(w3/4): rank 1 has no hit and must answer the start of chunk 1, not 0.If applicable: