Repository navigation
[Refactor] Move cache engine keys to in-process utils - #17
Merged
maobaolong merged 3 commits intoNov 17, 2026
Merged
Conversation
3 tasks
maobaolong
force-pushed
the
refactor/own-cache-engine-keys
branch
from
November 12, 2026 03:52
93b8261 to
71e93d8
Compare
Signed-off-by: baoloongmao <307499405@qq.com>
maobaolong
force-pushed
the
refactor/own-cache-engine-keys
branch
from
November 12, 2026 06:16
71e93d8 to
6405cf7
Compare
maobaolong
marked this pull request as ready for review
November 12, 2026 06:24
chunxiaozheng
approved these changes
Nov 12, 2026
chunxiaozheng
left a comment
There was a problem hiding this comment.
Thanks for the great work, LGTM!
Signed-off-by: baoloongmao <307499405@qq.com>
maobaolong
force-pushed
the
refactor/own-cache-engine-keys
branch
from
November 17, 2026 00:17
f718fe9 to
8f3ae2a
Compare
Signed-off-by: baoloongmao <307499405@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_cache_key,CacheEngineKey, andLayerCacheEngineKeyfrom LMCache'slmcache/utils.pytolmcache/inprocess/utils.pywithout changing their implementation, and update existing callers.--no-deps --force-reinstallin the CI dependency installer. Older LMCache distributions bundlelmcache/inprocess, which shadows an editable installation.lmcache.v1.common, includingkv_format.contiguity. Keep the old imports for the pinned snapshot and fall back to the relocated modules only when the old module paths are absent. Missing dependencies inside an existing module still raise their original errors.No new compatibility module or tests are added.
AGENTS.mdis unchanged. Connector functions and classes are unchanged.Companion removal: LMCache/LMCache#6575
Validation
Current head:
380cfba7a4e395bfe384c7a572b2d9edcc1184a9.cf87a1ca70fcea192dc3820c745aae0b9253061b, and all connector function/class definitions remain unchanged by the import fix.pre-commit run --all-files; source checks passed, while existing EOF/trailing-whitespace issues in legacy documentation remain outside this change and their automatic edits were reverted.