Skip to content

[Refactor] Move cache engine keys to in-process utils - #17

Merged
maobaolong merged 3 commits into
LMCache:mainfrom
maobaolong:refactor/own-cache-engine-keys
Nov 17, 2026
Merged

maobaolong merged 3 commits into
LMCache:mainfrom
maobaolong:refactor/own-cache-engine-keys

Conversation

@maobaolong

@maobaolong maobaolong commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Move parse_cache_key, CacheEngineKey, and LayerCacheEngineKey from LMCache's lmcache/utils.py to lmcache/inprocess/utils.py without changing their implementation, and update existing callers.
  • Install the current checkout as a regular wheel with --no-deps --force-reinstall in the CI dependency installer. Older LMCache distributions bundle lmcache/inprocess, which shadows an editable installation.
  • Adapt existing connector imports to the relocation of shared KV helpers to lmcache.v1.common, including kv_format.contiguity. Keep the old imports for the pinned snapshot and fall back to the relocated modules only when the old module paths are absent. Missing dependencies inside an existing module still raise their original errors.

No new compatibility module or tests are added. AGENTS.md is unchanged. Connector functions and classes are unchanged.

Companion removal: LMCache/LMCache#6575

Validation

Current head: 380cfba7a4e395bfe384c7a572b2d9edcc1184a9.

  • Azure integration: passed against Azurite.
  • CI: Code quality passed. At the latest check, the wheel build and four smoke jobs were still queued for runners; their results are pending.
  • AST comparison confirms the three migrated definitions match LMCache snapshot cf87a1ca70fcea192dc3820c745aae0b9253061b, and all connector function/class definitions remain unchanged by the import fix.
  • All pre-commit hooks passed on the changed connector files. Ran pre-commit run --all-files; source checks passed, while existing EOF/trailing-whitespace issues in legacy documentation remain outside this change and their automatic edits were reverted.

Signed-off-by: baoloongmao <307499405@qq.com>
@maobaolong
maobaolong force-pushed the refactor/own-cache-engine-keys branch from 71e93d8 to 6405cf7 Compare November 12, 2026 06:16
@maobaolong maobaolong changed the title [Refactor] Own legacy cache engine keys in-process [Refactor] Move cache engine keys to in-process utils Nov 12, 2026
@maobaolong
maobaolong marked this pull request as ready for review November 12, 2026 06:24

@chunxiaozheng chunxiaozheng left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work, LGTM!

Signed-off-by: baoloongmao <307499405@qq.com>
@maobaolong
maobaolong force-pushed the refactor/own-cache-engine-keys branch from f718fe9 to 8f3ae2a Compare November 17, 2026 00:17
Signed-off-by: baoloongmao <307499405@qq.com>
@maobaolong
maobaolong merged commit 8fc5c99 into LMCache:main Nov 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants