Repository navigation
fix(mobile): retain paired LAN and relay connections - #855
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
Closes #840
Pairing LAN and relay for the same computer now keeps both authenticated routes in one saved computer entry. Connections try LAN first, with a five-second budget before trying the saved relay. Reconnects preserve the workspace and unsent draft. Disconnected cards show “LAN + Relay”; connected cards show the active transport.
Previously overwritten credentials cannot be recovered. Pair the missing transport again once to retain both routes.
Design / 设计边界
RelayProfileretains one alternate route for the same authenticated Noise host key. Each route keeps its own endpoint, TLS pin and credentials in the existing encrypted store; the 64-computer limit remains unchanged.SessionRepositoryowns each bounded connection attempt and reuses existing reconnect backoff and stale-client checks. Certificate, authentication and protocol failures stop fallback. New invitations and edited addresses must authenticate before replacing saved routes.architecture/notes/mobile/android/app/connection/2026-11-01-paired-lan-relay-routes.md.Evidence / 验证依据
RelayRoutesTesttests passed, covering both pairing orders, storage round trips, route replacement, legacy records, invalid alternates, LAN preference and failure boundaries.DesktopRecoveryTestmethods passed, including the new dual-route regression and existing foreground/network recovery, certificate failure, repeated pairing, stalled invitation and authenticated LAN rediscovery tests.HomeSessionsTestUI regression and physical-device/network acceptance were not run.RelayProfilefrom base42ffd11ffails the storage reproduction: pairing relay loses the previously saved LAN address.cargo test --locked -p nebula --features gpui-test-support --no-fail-fast -- --test-threads=1: 2,723 unit tests passed, 1 failed, 36 ignored; 27 integration tests passed, 1 ignored. The failure isgit_completion::tests::real_branches_cache_invalidation_and_directory_context(nested release-tag completion). Its Rust source matches the PR base; this Android-only change does not alter it. The first build was killed by SIGKILL; a retry completed. Builds used one job, no incremental compilation/debug information, and constrained glibc allocator arenas.cargo clippy --locked -p nebula --all-targets --features gpui-test-support: blocked by 19 existing errors innebula_terminal, whose source also matches the PR base. No lints or tests were disabled.python3 scripts/check_architecture.py --base 42ffd11ff95db61eacaf026319c0bfb3bed3bea1, the three architecture/governance unittest modules (55 passed),cargo fmt --all -- --check, XML parsing for both changed catalogs, andgit diff --check: passed.Required Review / 必须确认
CONTRIBUTING.md, the architecture documentation and project constraints.