Repository navigation
fix(terminal): page full-screen Pi without mouse reporting - #854
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Result / 用户结果
Closes #781
When a current Pi workload uses the alternate screen with alternate scrolling enabled and no application mouse reporting, an unmodified wheel event now sends one PageUp/PageDown command instead of cursor arrows. Fractional wheel deltas still accumulate before paging. Existing application mouse reporting takes priority, and other foreground programs retain their existing scrolling behavior.
Design / 设计边界
architecture/notes/nebula_app/gpui_shell/terminal/view/2026-10-31-pi-wheel-paging.md.Evidence / 验证依据
cargo test --locked -p nebula --features gpui-test-support --bin pebrel pointer:: -- --test-threads=1: 43 passed.cargo test --locked -p nebula --features gpui-test-support --no-fail-fast -- --test-threads=1: 2,725 unit tests passed, 36 ignored, 1 failed; 27 integration tests passed, 1 ignored. The sole failure isgit_completion::tests::real_branches_cache_invalidation_and_directory_context(nested release-tag completion), also reproduced in the pre-change test binary. Its source matchesorigin/main.cargo check --locked -p nebula --bin pebrel --features gpui-shell --tests: passed, with warnings in unchanged code.cargo clippy --locked -p nebula --all-targets --features gpui-test-support: blocked by 19 existing errors innebula_terminal. The core source matchesorigin/main;cargo clippy --locked -p nebula_terminalreproduces the same diagnostics and locations. No lint rules were weakened.cargo test --locked -p nebula-settings: 107 passed. The isolated i18n contract suite: 24 passed, 1 ignored.cargo fmt --all -- --check,git diff --check, andpython3 scripts/check_architecture.py --base 42ffd11ff95db61eacaf026319c0bfb3bed3bea1: passed. The three architecture/governance unittest modules: 55 passed.Local builds used one Cargo job, disabled incremental compilation and debug information. Two early test builds were killed with SIGKILL during code generation; the completed builds used
MALLOC_ARENA_MAX=1 MALLOC_TRIM_THRESHOLD_=0 MALLOC_TOP_PAD_=0, cleared by the Cargo runner for test execution. Clippy was also attempted with a command-lineprofile.dev.package.nebula.codegen-units=256override. No build configuration files changed.The existing pre-fix test binary reproduced the defect: one three-line wheel event emitted three Up-arrow sequences instead of PageUp. The regression dispatches through the real terminal element and covers both directions, one-page batching, fractional accumulation, Kitty encoding, SGR precedence, stale identity, explicit program status, and alternate-screen exit. Routing tests cover mode and modifier exclusions.
The batching assertion observes one transport message per event. Identity normalization and key encoding may allocate; no allocation-free or universal performance claim is made.
Linux validation uses virtual GPUI windows. Live Pi, native macOS-to-Windows SSH, and visual/platform acceptance were not run. This fixes the fallback when mouse reporting is absent; it does not establish why reporting was unavailable in the original SSH connection. Pi owns its internal transcript and scrollbar; the test confirms Pebrel has no local scrollback thumb on that alternate screen.
Required Review / 必须确认
CONTRIBUTING.md,docs/architecture.md, anddocs/project-constraints.md.