Repository navigation
Conversation
Expose CopyWorkingDirectory in the editable keymap with Ctrl+Shift+L (Shift+Cmd+L on macOS), matching the tab menu and command palette action.
Remove one trailing blank line so check_architecture stays at the 2575-line cap after adding CopyWorkingDirectory. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
I'll fix it later when I have some free time. |
Updating the keymap filter expectations after adding the copy-cwd action. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Please check this over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose CopyWorkingDirectory in the editable keymap with Ctrl+Shift+L (Shift+Cmd+L on macOS), matching the tab menu and command palette action.
Advertising, commercial promotion, and traffic solicitation are prohibited in PRs
and Issues. Business requests must go through the email in the
contribution policy.
PRs or Issues containing unauthorized promotion will be closed directly.
严禁利用 PR 或 Issue 推广、引流,未经授权的推广将直接关闭;商业需求请通过贡献指南中的邮箱沟通,已获批准的赞助按批准范围处理。
Result / 用户结果
Design / 设计边界
config::Action::CopyWorkingDirectory; GPUICopyWorkingDirectoryworkspace action delegates to existingTerminalView::copy_working_directory; legacy input path usesfocused_cwd_string()+ clipboard (same as paletteCopyCwd).CommonCopyWorkingDirectory/CommonCwdCopied); SSH tab naming and cwd reporting rules unchanged.keybind=lines unaffected unless they override the same combo.Evidence / 验证依据
cargo check -p nebula --bin pebrel --features gpui-test-support— passes locally.copy_working_directory_default_binds_gpui_actionand extended default-combo coverage forctrl+shift+l;hardcoded_migrationlist updated. Fullcargo testforpebrelnot run locally (missinglibxkbcommon-x11on this machine); CI expected to run project checks.Required Review / 必须确认
CONTRIBUTING.md,docs/architecture.md, anddocs/project-constraints.md.python3 scripts/check_architecture.py --base <PR-base-commit>passes; budgets were not inflated to fit the change.Message::CommonCopyWorkingDirectory; no new catalog IDs.)Checkboxes explain the review; they do not replace CI or maintainer approval.