fix: restore post-merge build integrity - #19
Merged
Conversation
- include the missing domain compaction implementation and tests - align strict CIDR parser tests with fail-closed behavior - reuse RULES_COMPILE_JOBS and its bounded concurrency validation - verify every compiled binary exists and is non-empty - fix zero-count statistics and reduce per-file subprocess overhead - remove non-equivalent regex fallback rules and unverified benchmarks - document platform conversion loss without approximating semantics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Findings fixed
The merged optimization passed the PR quick check but broke the full
Sync Rulesworkflow. This repair restores the missing cross-file implementation and aligns tests with the new fail-closed parser behavior.Fixes
export-domain-rules.pyRULES_COMPILE_JOBSwith validated, bounded concurrencyVerification
REQUIRE_SHELLCHECK=1 make validate: 28/28 tests passedREQUIRE_SHELLCHECK=1 make preflight: passed, including text artifact build