Ignore masks with a zero width or height - #455
Open
DSeaStar wants to merge 1 commit into
Open
Conversation
SVGSurface rejects a 0x0 canvas, so a mask whose width or height is 0 raised ValueError instead of being treated as a no-op. Skip those masks the same way zero-size patterns are already skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #440.
A mask whose
widthorheightis 0 madepaint_maskbuild anSVGSurfacefor an empty canvas, which raisesValueError: The SVG size is undefined. That is what happens with SVGs such as the Wikimedia limpet diagram in the issue: they include unused masks (and similar defs) sized to 0.draw_patternalready treats a zero-size pattern as a no-op. Do the same for masks, and fall back to painting the group when the mask is skipped so the element is still drawn.