fix(realtime): fetch rows from custom Postgres schemas - #171
Conversation
|
@codex review. Please review code and security on the current head. Python custom-schema Postgres INSERT/UPDATE notifications now fetch the schema-qualified row, matching existing JavaScript and Ruby behavior. The public/private delivery regression failed for private before the fix and passes now; captured credentials, disabled fetching, error fallback, and generation boundaries remain intact. All 1117 native tests, Ruff, mypy, Pyright, deterministic generation, build/package, and docs checks pass. This is a native facade correction with no shared scenario or wire change. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4ccd370a79
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Insert a row from another client during the listening period. | ||
| Automatic row lookup requires a primary key named `id`. It reads the current row after the notification; rapid updates may have already changed that row. | ||
| Matching insert and update notifications in the `public` schema can fetch full rows using the subscription's user token. | ||
| Matching insert and update notifications can fetch full rows using the subscription's user token. |
There was a problem hiding this comment.
Update the main README alongside this behavior change: its Postgres section still states that automatic fetching applies only to the public schema and that non-public schemas retain lightweight notifications (README.md lines 770–776). Users following that contract may bind a database without setting auto_fetch=False and unexpectedly issue row queries for custom-schema notifications.
Useful? React with 👍 / 👎.
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review. Please rerun code and security reviews on the current head. The README now agrees with the realtime guide: automatic lookups support public and custom schemas, preserve the schema, and retain lightweight events on missing rows or query failure. Runtime and native regression are unchanged; all previous native/type/generation/package checks pass, and docs lint passes. |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
1 participant
Python delivered lightweight INSERT/UPDATE notifications from custom Postgres schemas without fetching their rows, while JavaScript and Ruby performed schema-qualified lookups. Preserve the schema in the Python lookup so automatic delivery works for both public and custom schemas. Disabled fetching and failed lookups still retain the lightweight event.
The public/private delivery regression failed for the custom schema before the fix. Validation: 1117 unit tests, Ruff, mypy, Pyright, deterministic generation, wheel/sdist build, isolated package checks, and docs lint pass. The existing public-schema shared scenario is unchanged; this corrects the native facade to the established cross-language behavior. Hosting #1127 remains the cumulative integration PR and merges last.