test(realtime): stage presence membership acceptance - #168
Conversation
|
@codex review. Please review code and security on the current head. This stages SDK-REALTIME-003 for server connection/user identity and original callback membership changes, with native regressions and bounded cleanup. All native checks and current/proposed feature-copy validation pass; 37 proposed scenarios register. Coordinated SDK PRs: JavaScript #134, Python #168, Ruby #150. Hosting #1127 remains the integration PR and merges last; live presence validation follows SDK merges. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
1 participant
Stage SDK-REALTIME-003 for two authenticated connections sharing one presence channel. Verify both rosters retain the server connection identity and user, then confirm the original callback observes 1 → 2 → 1 members as the second connection joins and leaves. Cleanup closes both subscriptions; waits have ten-second deadlines.
Add the Python realtime guide covering native lifecycle, presence, database changes, and shutdown. Existing active features remain unchanged; the staged feature is byte-identical to the proposed Hosting #1127 source. Hosting merges last after all SDK dependencies and live validation.
Validation: 1,108 native tests; lint, mypy, pyright, deterministic generation, wheel/sdist build, isolated package smoke, and docs lint pass. All 37 proposed scenarios / 207 steps register in Behave dry-run. The sequence regressions reject a missing initial or final callback. Current Hosting compatibility and proposed feature-copy validation are checked across the three SDKs. Live presence validation is pending dependency merges.