Update permission system - #287
Merged
Merged
Conversation
- add PermissionService to centralize role evaluation and permission checks - refactor template and component permission guards to use the new service - remove redundant AllowAnnotatingService and obsolete RxJS boilerplate - enhance maintainability by decoupling components from explicit role checking
HeyItsBATMAN
approved these changes
Jul 27, 2026
HeyItsBATMAN
left a comment
HeyItsBATMAN
left a comment
Member
There was a problem hiding this comment.
LGTM. PermissionService may be updated in the future to also check for the current profile selected (personal or organizational), but since profiles are not fully implemented yet, this can wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regarding issue #279 :