Repository navigation
Health duplicates: say why books were grouped; hold another edition's match for review - #131
Merged
Merged
Conversation
…n the lengths differ (#129) Duplicate groups now carry the reason their joins support: same_id (a shared ASIN or ISBN of matching lengths) and id_length_differs (a shared identifier of lengths that don't match, every pair of its holders compared) beside same_files and same_book. id_length_differs outranks even identical audio, as such a group holds a different recording. The console words each reason and, for id_length_differs, marks no copy as the one to keep and says what to check.
…fident The closest recording of a work can be another edition: the unabridged The Burning (7h 13m) scored 90 against a work holding only its 357-minute dramatization, 24 ahead of the next, and took its ASIN unasked. Such a match is now left for review. CLAUDE.md: the duplicate reasons and the length rule.
…for review A shared ASIN/ISBN joins its holders in one pass, judged by the shortest and longest known lengths (an unknown length is no evidence they differ). The 10% band is meta.PlausibleRuntimeOff and meta.RuntimeOff, shared by the scorer and lengthFits, which a refresh run now applies too. The reason constants are package-private, the metaKey join marks nothing, and the console's warning is a StatusText.
A group a shared identifier joined differs when its shortest and longest known lengths do, so a book of unknown length can't bridge two recordings into copies. The ignored view drops the 'say they're different books' advice, fixtures carry their own lengths, and the refresh comments name the length hold.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #129.
Two books that share an ASIN or ISBN were grouped as duplicates whatever their lengths, and labelled "same title, author and length". The reported pair (The Burning, a 5h57m full-cast dramatization and a 7h13m unabridged reading) got there because a confident auto-match wrote the dramatization's ASIN onto the unabridged book: the community data holds only the dramatized recording, and it scored 90 despite an 18% length gap.
Duplicates
same_id(a shared ASIN/ISBN, matching lengths) andid_length_differs(a shared ASIN/ISBN whose group lengths don't match). Order:id_length_differs>same_files>same_id>same_book.id_length_differs, so it never nudges deleting a different recording.Matching
meta.PlausibleRuntimeOff, now shared with the scorer). A refresh run holds such a book for review too.Docs: KodeStar/audiosilo-docs (docs/duplicate-reasons).
Follow-ups not in this PR: the community data lacks the Guidall unabridged recording of The Burning (and the work's title lacks "[Dramatized Adaptation]"); a review item held for length carries no detail saying why.