Implement keyboard.show for html5 - #1537
Open
RblSb wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keyboard.show()now creates hidden focused input html element to show virtual keyboard, resends keydown/up events to game canvas and generates direct keypress events when input value updated.canvas.onkeypress = keyPress;is removed for simplification, key presses are generated from keydown events like so:Using
event.keyinstead of oldevent.whichshould be good, it's seems like a standard way to catch keypresses now and works since IE9.I also added these small fixes while testing:
MobileWebAudio._context == nullcheck to fix ios simulator crash on first click when mobile web audio is enablediosTouchson pointer cancel event and do not setiosTouchs[-1] = -1;accidentally