Quarantine eight false MediaDive material aliases with complete audit evidence - #1264
Merged
Merged
Conversation
Collaborator
Author
|
Final review checkpoint for exact PR head
The #1266 correction passed 135 tests (96 authored, 22 new independent, 17 inherited independent). This closes the bounded source acceptance for #1262/#1263; it is not release acceptance. #650 and #286 remain open pending the fresh all-15 rebuild, candidate-only merge, model/path/content review and evidence packaging. #1265's additional source-to-merge preservation check must run against that candidate. Local evidence: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Closes #1262. Closes #1263. References #650 and #286; neither umbrella issue is
closed by this change.
Withhold eight evidence-reviewed MediaDive material-name/ChEBI pairs whose
native chemical identities do not describe the source materials:
The immutable source/native/mapping fixture records 289 affected source
observations and thirteen complete erroneous lexical alias rows. This includes
256 nested solution references across seven distinct solution IDs; those IDs,
recipes, quantities and contexts must remain distinct. No replacement identity
is inferred, including for the unresolved source spelling
K2HSO4.Changes and preservation
all-target material holds. Independently selected alternatives remain visible
and require appropriate scientific review.
ordinals and baseline provenance after derived mapping removal. Historical
claims are audit evidence, never active identity mappings.
binding, including empty cohorts, full source occurrence/context, current
grounding candidates and actual retained targets.
and actual reader-compatible target whitespace handling. Eligible current
rows retain full fields and duplicate row multiplicity.
chelator-role, kinetin and TMAC-chloride controls, and unrelated material
policies. Do not reinterpret weak relations as chemical identity.
Science and reproducible native/source witnesses are documented in
docs/reviews/mediadive-material-aliases-1262.mdandtests/resources/mediadive/material_aliases_1262.json.Verification checkpoint
24 independent adversarial probes plus 40 authored tests.
rows, zero relabels, 591,933 retained rows with all remaining row bytes,
ordering and multiplicity unchanged. Metadata changes only the reviewed
policy fingerprint; original writer provenance is retained.
compared, unrelated entries and native controls preserved, no new alternative,
and a byte-identical second build. The first attempt was retained as rejected
evidence after a planning-document addition changed directory membership;
the fresh second attempt reran all phases and passed unchanged-input guards.
Post-installation native-pair/policy/audit verification: 193 tests passed.
promotion. The finite full-source comparison helper passed 83 hermetic cases,
including 17 independent adversarial probes; this is not a source replay.
and manual node review; all four repository gates; exact-head CI.
This checkpoint is not production rebuild, merged-graph acceptance, publication
or release approval. The all-source rebuild and broader #650/#286 acceptance
remain separate work.