Normalize KEGG compound xref annotations without changing identities - #1260
Conversation
|
Independent adversarial code review cleared the three-file #1259 patch with no
The reviewer ran 51 passing hermetic cases, including 16 independently authored Review report SHA-256: The separate full-artifact reader comparison, all four repository gates and |
|
Actual full-artifact reader comparison passes for #1259 at
Evidence: The actual comparison preceded the later #1261 test-only CodeSpell suppression for This validates reader compatibility, not physical SSSOM cleanup or historical chemical-conflict resolution. Full gates/CI and subsequent production rebuild, emitted-output and merged-KG acceptance remain separate requirements. |
#1261 one-comment fix: independent clearanceCompared the W10 test to commit - "hsa:12345",
+ "hsa:12345", # codespell:ignore hsaThe complete parsed AST is identical, including all assertions and all 123 Verified SHA-256 before and after checks: The 35 focused tests passed in 4.34 seconds (exit 0, four dependency warnings), No actionable finding. This clears the comment-only fix; restarted full gates |
Summary
Fixes #1259.
Fixes #1261.
Normalize only the exact historical
kegg.compound:cpd:C[0-9]{5}spelling inemitted node xrefs. Preserve the original SSSOM, lookup keys, precedence and
identity decisions. The test-only CodeSpell exception is limited to one valid
negative-control literal.
Independent review and completed checks
entities reviewed, with 15,311 annotation-only normalizations. Its receipt is
bound to actual execution at
980c8234..., not restamped. The later Preserve valid hsa namespace fixture under CodeSpell in #1259 tests #1261comment-only change has independently verified unchanged AST and literals.
02f6e128dce6c16a95230266cd9123a69530b9e1, clean.poetry run pytest: 5,228 passed, 18 skipped.poetry run tox: all six default environments pass, including isolatedpytest with 5,229 passed, 17 skipped.
poetry check --lockand generated merge-config check both pass.edges byte-identical, all 32,135 nodes retained, exactly 11 redundant xref
spellings removed. No new canonical xref claim; all other cells unchanged.
only the explicitly approved worktree path relocations differ.
Evidence directory:
data/issue1224-quarantine-20260929.xjuS9H/issue1259-diagnosis.7T9Jn8/.495065dad3785fcddb8d7a4ee630c58e2c14fab5ed73e1d4177570dd342664205fd7838b44387f23fa49cbd1a1d45766d2863832f74b242a57666d8a958f114672c9a0cca834d0ef1d651c9a3d6f0f15a3e022f9dfacd3c95f88c1c32cee9a922963b5ffeb45650eada089263e3d84a0421d398aea99d32c4e942ad8d07f3d42Earlier failed CI and interrupted local gates remain historical failures, not
relabelled as passing. All owned gate and replay groups have settled.
Boundaries
This annotation correction does not approve inherited material-to-molecule
assignments discovered during node review. They are separate upstream mapping
work and must be resolved before the full production rebuild. The chemical
mapping skill kept the current change within output annotations; the supported
MIM table and immutable pin remain unchanged.
Umbrella issues #650 and #286 remain OPEN. The fresh all-source transform,
candidate-only merge and source/KG/model/path acceptance are still required.
The canonical archive and user statistics are protected and unchanged.
Admin bypass of the required collaborator approval was explicitly authorized
only after independent review and green CI; those scoped conditions now hold.