Preserve scoped material identities and correct audited BacDive substrates - #1256
Conversation
|
Independent exact-head review of All 27 source/policy/fixture/science-document paths match previously reviewed bytes; the three staging changes are the accepted Verified the actual 19-test and 584-test passing receipts without duplicating them. The successful three-phase consumer receipt is correctly identified as pre-BacDive integration; its 16 imported runtime modules remain byte-identical, and the only expected subsequent mapping-input change is accepted candidate staging. No execution was restamped as a new-head run. This is source/artifact review clearance, not release approval. Actual combined MediaDive replay/comparison and manual node review, complete repository gates, and exact-head CI remain required before merge. Fresh all-source transforms, candidate merge, retained audit evidence, and final KG reviews remain separate release gates; umbrella #286 and #650 are not closed by this review. |
Fixes #1257. The two formatting hunks preserve the complete Python AST and all scientific assertions.
|
Independent continuity review at The original gate receipt remains correctly failed for its dirty-tree guard, not restamped as green. Verified logs show full pytest passed (5,160/51 skipped) and all six default tox environments passed (tox pytest: 5,161/50 skipped). The new-head focused 19 tests passed; the coordinator separately completed stable formatting, lock and merge-config checks with clean head guards. This clears source/test continuity, not final acceptance. Exact-head three-version CI and actual combined MediaDive replay/comparison with manual node review remain pending. Fresh all-source transforms, candidate merge, retained audit evidence and final KG reviews remain separate release gates; umbrella #286/#650 are not closed. |
|
Independent actual MediaDive review at The isolated producer replay succeeded. Corrected full comparison ( Reviewed every affected node field: four obsolete source declarations removed only after their incidence reaches zero, five correctly named/scoped nodes added; all other node rows unchanged. Soy peptone correctly retains its existing ComplexMolecularMixture category. The chloride target, raw display name, native CAS/KEGG reference and synonym are supported. Exception: chloride enrichment also exposes pre-existing malformed Exact-head CI and final production/merged-KG acceptance remain separate gates. This review does not close #286/#650 or declare the current merged graph release-ready. |
Summary
Finite evidence-backed material and substrate corrections upstream of the
#650/#286 production rebuild, retaining original claims in mandatory audits.
peptone materials on source-local nodes, without inventing molecular identity.
unqualified-parent behavior.
structural-label-only changes, with unrelated rows unchanged. Unified SHA-256
67c48e1bf6bed1f1fef03a0da1d7d1b56af9fc72374dddd703c222fb36df3cd4.require the correction policy/raw input and source audit at finalization.
Supported MIM and its immutable upstream pin remain unchanged.
Completed validation
Merged revision
de22343a328df57e2ab0fda3c09741be87162999, reviewed head1329368de7feb835baa4f19f63fd945fe9207f1a. Independent source, mapping and actualMediaDive node/audit reviews are posted in this PR.
passed, including 5,161 passed / 50 skipped in its pytest run. The original
runner correctly failed its clean-tree guard after formatter-only edits;
retained failed receipt is not restamped. Independently verified identical
test AST and source/mapping trees support the bounded formatting continuation.
generated merge-config checks passed.
36576348968: Python 3.10, 3.11, 3.12 all passed.normal source admission, unchanged inputs. Full comparison verifies 29 intended
target changes, 113,897 otherwise unchanged edge rows, and all 225 audit rows.
incidence for removed declarations. Inherited malformed KEGG annotation is
explicitly tracked in Normalize inherited double-prefixed KEGG compound xrefs before rebuild #1259 for repair before the final rebuild/release.
The finite checker defect #1258 was independently fixed and retested; its
original failed comparison is retained alongside the successful new attempt.
Fixes #1241
Fixes #1242
Fixes #1243
Fixes #1245
Fixes #1248
Fixes #1249
Fixes #1250
Fixes #1252
Fixes #1257
Umbrellas #650 and #286 remain OPEN pending the fresh all-15-source rebuild,
candidate-only merge, full KG/model/path acceptance and evidence retention.
This PR is not release authorization; the canonical archive and user statistics
remain untouched.