Quarantine reviewed MicrobeDecoder crosswalk contradictions with retained evidence - #1228
Merged
Merged
Conversation
Collaborator
Author
|
Exact-head acceptance for
Evidence root: The user explicitly authorized admin bypass of the required collaborator approval after independent review and green CI. Those prerequisites are now satisfied for this exact head; the planned squash merge will use |
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the user's approved conservative disposition for #1224: quarantine only individually reviewed, authority-contradicted MicrobeDecoder NCBI/GOLD links. Preserve the complete original claim, source record and scientific evidence outside the assertion graph. Do not infer a replacement identity; preserve assembly/IMG and insufficiently supported links.
crosswalk_quarantine.tsvevidence at producer completion, staged finalization, repeat finalization and merge admission. Missing, changed, symlinked or omitted evidence fails closed.Independent adversarial review
Two reviewers independently checked scientific admission/package evidence and runtime/finalization behavior. Review findings were filed and fixed:
Final independent runtime probes: 20 passed. Existing-test adaptations: 226 passed. Focused consumer/audit/witness tests pass; formatting, lint, spelling and 100% docstring checks pass.
Completed local/source acceptance — not release approval
Exact committed head:
5637c2678dbcd4342c0b927439d755e97eebe54d.poetry run pytest(4,761 passed, 56 skipped),poetry run tox(all environments passed),poetry check --lock, and generated merge-config check. Final gate receipt SHA-256:b534c7450720abe0aa0e43753485567c52db79041acd38c6be4b592f1bd37a20. Candidate HEAD and tracked/untracked cleanliness guards passed; the only explicitly allowed untracked file was the pinned local.venvsymlink.test_biolink_hierarchy.pyandtest_biolink_schema_pin.py: 34 passed, no skips. This is supplemental coverage, not a replacement or inflated total for the full-suite result above.Exact-head GitHub CI is green on Python 3.10, 3.11 and 3.12: run 36538573179. The last matrix job completed successfully at 2026-09-29 08:10:57 UTC. Local/source evidence is under
data/issue1224-quarantine-20260929.xjuS9H/, includingexact-head-review.md,final-gates-t515_ncy/results.json, andsource-replay/attempt-61wnnzqd/graph-review/TRIAGE.md.Separate local production-content helper review found and fixed #1229/#1230/#1231 (archive padding, exact evidence types, mixed primary providers). Final independent and main-agent reruns both pass all 78 tests. Those helpers are not product changes in this PR and have not been used to accept a production candidate.
No production transform output, merged archive or user-modified statistics file was changed. Full production rebuild and merged modeling/path/KGXVal acceptance remain tracked under #650. Remaining unadjudicated crosswalks are not certified correct by this PR.
Fixes #1224.
Fixes #1225.
Fixes #1226.
Related to #650 and #1227.