Centralize hierarchical classification changes - #1848
Open
PaulHax wants to merge 5 commits into
Open
Conversation
This was referenced Aug 14, 2026
PaulHax
marked this pull request as ready for review
August 14, 2026 03:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Centralize hierarchical classification changes
PR 1 lets several user actions change classifications through existing model methods. In a
multicamera dataset, those methods can change only one camera or a temporary merged track.
This PR adds commands for one logical track. A command calculates one canonical confidence vector.
It then installs independent copies on all linked camera tracks.
Changes
CameraStorecommands for all linked camera tracks.new commands.
Behavior
1.0. It keeps related pairs and removesunrelated pairs.
1.0does not accept the pair as correct.Manual tests
Test data: download and extract
classification.zip. Paths
below are relative to
dive-classification-test-data/.Single-camera classification commands
dive-classification-test-data/classification/single-camera-linked-types/.1.0without accepting it, and remove one pair.Verify: Reassignment changes one lineage, acceptance removes only unrelated pairs, a normal
1.0edit keeps unrelated pairs, and pair removal removes only the selected pair.
Multicamera classification synchronization
dive-classification-test-data/classification/multicamera-linked-types/.action.
Verify: Both camera tracks contain equal confidence vectors after each action.
Stack
This is PR 5 of 9. Previous: add hierarchical track classification.
Next: add read-only track projections.
This PR is stacked on
hierarchical-classification-pr1.Overall: 22 files, +1,036/-50. Commits:
b1774226through1d2597d6.