Allow devDependency imports in TypeScript spec files

client/dive-common/components/AttributeTrackFilter.vue

@@ -1,5 +1,4 @@
 <script lang="ts">
-/* eslint-disable max-len */
 import { computed, defineComponent, ref } from 'vue';
 import { throttle } from 'lodash';
 import { useAttributes, useTrackFilters, useTrackStyleManager } from 'vue-media-annotator/provides';

client/dive-common/components/DatasetInfo/DatasetInfo.spec.ts

@@ -1,5 +1,4 @@
 // @vitest-environment jsdom
-/* eslint-disable import/no-extraneous-dependencies */
 import { mount } from '@vue/test-utils';
 import Vue, {
   CreateElement, defineComponent, nextTick, ref,

client/dive-common/components/ImportMultiCamDialog/multicamSubfolderLayout.spec.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-extraneous-dependencies -- Vitest is only used in tests
 import { describe, expect, it } from 'vitest';
 
 import {

client/dive-common/components/PrimaryAttributeTrackFilter.vue

@@ -1,5 +1,4 @@
 <script lang="ts">
-/* eslint-disable max-len */
 import {
   computed, defineComponent, PropType, ref,
 } from 'vue';

client/dive-common/components/Viewer.vue

@@ -1662,7 +1662,6 @@ export default defineComponent({
           }
           cameraStore.addCamera(camera);
           addSaveCamera(camera);
-          // eslint-disable-next-line no-await-in-loop
           const {
             tracks,
             groups,

client/dive-common/components/importAnnotationsSets.spec.ts

@@ -1,6 +1,5 @@
 // @vitest-environment jsdom
 import { defineComponent, h, ref } from 'vue';
-// eslint-disable-next-line import/no-extraneous-dependencies -- @vue/test-utils is only used in tests
 import { mount } from '@vue/test-utils';
 import { provideAnnotator, dummyState, dummyHandler } from 'vue-media-annotator/provides';
 import { provideApi } from 'dive-common/apispec';

client/dive-common/compositeDatasetId.spec.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-extraneous-dependencies -- Vitest is only used in tests
 import { describe, expect, it } from 'vitest';
 
 import { parentDatasetId, parseCompositeDatasetId } from './compositeDatasetId';

client/dive-common/recipes/polygonbase.ts

@@ -263,7 +263,6 @@ export default class PolygonBoundsExpand implements Recipe {
     }
   }
 
-  // eslint-disable-next-line class-methods-use-this
   activate() {
     // no-op
     this.active.value = true;
@@ -274,7 +273,6 @@ export default class PolygonBoundsExpand implements Recipe {
     });
   }
 
-  // eslint-disable-next-line class-methods-use-this
   deactivate() {
     // no-op
     this.active.value = false;

client/dive-common/recipes/segmentationpointclick.ts

@@ -457,7 +457,6 @@ export default class SegmentationPointClick implements Recipe {
   update(
     mode: 'in-progress' | 'editing',
     frameNum: number,
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     track: Track,
     data: GeoJSON.Feature<GeoJSON.LineString | GeoJSON.Polygon | GeoJSON.Point>[],
     // eslint-disable-next-line @typescript-eslint/no-unused-vars

client/dive-common/stereoParentFolder.spec.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-extraneous-dependencies -- Vitest is only used in tests
 import { describe, expect, it } from 'vitest';
 
 import { commonPathPrefix } from 'dive-common/components/ImportMultiCamDialog/multicamSubfolderLayout';

client/dive-common/use/stereo/tests/stereoOnnx.spec.ts

@@ -1,7 +1,6 @@
 import { readFileSync } from 'fs';
 import { fileURLToPath } from 'url';
 import { PNG } from 'pngjs';
-// eslint-disable-next-line import/no-extraneous-dependencies -- Vitest is only used in tests
 import {
   describe, it, expect,
 } from 'vitest';

client/dive-common/use/stereo/tests/stereoTransfer.spec.ts

@@ -1,7 +1,6 @@
 import { readFileSync } from 'fs';
 import { fileURLToPath } from 'url';
 import { ref } from 'vue';
-// eslint-disable-next-line import/no-extraneous-dependencies -- Vitest is only used in tests
 import {
   describe, it, expect, vi,
 } from 'vitest';

client/dive-common/use/stereo/tests/triangulate.spec.ts

@@ -1,6 +1,5 @@
 import { readFileSync } from 'fs';
 import { fileURLToPath } from 'url';
-// eslint-disable-next-line import/no-extraneous-dependencies -- Vitest is only used in tests
 import {
   describe, it, expect,
 } from 'vitest';

client/dive-common/use/stereo/useStereoOnnxTransfer.ts

@@ -466,7 +466,6 @@ export default function useStereoOnnxTransfer(config: StereoOnnxTransferConfig)
     });
 
     // Sequential: each job runs a wasm inference and reads frame pixels.
-    // eslint-disable-next-line no-restricted-syntax
     for (let i = 0; i < jobs.length; i += 1) {
       config.onStatus?.(`Warping detection ${i + 1} of ${jobs.length}...`);
       // eslint-disable-next-line no-await-in-loop

client/dive-common/use/useFrameMetadata.spec.ts

@@ -1,6 +1,5 @@
 import { effectScope, nextTick, ref } from 'vue';
 
-// eslint-disable-next-line import/no-extraneous-dependencies -- Vitest is only used in tests
 import {
   beforeEach, describe, expect, it, vi,
 } from 'vitest';

client/package.json

@@ -19,7 +19,7 @@
     "build:electron": "electron-vite build && electron-builder --config electron-builder.json",
     "build:electron:dir": "electron-vite build && electron-builder --config electron-builder.json --dir",
     "divecli": "node ./bin/platform/desktop/backend/cli.js",
-    "lint": "eslint --ext .js,.ts,.vue src/ dive-common/ platform/",
+    "lint": "eslint --ext .js,.ts,.vue --report-unused-disable-directives src/ dive-common/ platform/",
     "lint:templates": "eslint --ext vue src/ dive-common/ platform/",
     "test": "vitest run src/ dive-common/ platform/",
     "typecheck": "vue-tsc --noEmit -p tsconfig.typecheck.json"
@@ -183,6 +183,19 @@
           "@vue/typescript",
           "@vue/typescript/recommended"
         ]
+      },
+      {
+        "files": [
+          "**/*.spec.ts"
+        ],
+        "rules": {
+          "import/no-extraneous-dependencies": [
+            "error",
+            {
+              "devDependencies": true
+            }
+          ]
+        }
       }
     ],
     "parserOptions": {

client/platform/desktop/backend/native/attributeProcessor.spec.ts

@@ -1,6 +1,3 @@
-/* eslint-disable quote-props */
-/* eslint-disable @typescript-eslint/naming-convention */
-
 import { MultiTrackRecord } from 'dive-common/apispec';
 import { TrackData } from 'vue-media-annotator/track';
 import type { Attribute } from 'vue-media-annotator/use/AttributeTypes';

client/platform/desktop/backend/native/attributeProcessor.ts

@@ -62,7 +62,6 @@ function processTrackAttributes(tracks: TrackData[]):
         if (lowCount >= predefinedMinCount && attributeType.indexOf('text') !== -1) {
           attributeObj[attributeKey].values = values;
         }
-        // eslint-disable-next-line no-param-reassign
         attributeObj[attributeKey].datatype = attributeType;
       }
     });

client/platform/desktop/backend/native/cameraRegistration.ts

@@ -25,7 +25,6 @@ import {
 } from 'dive-common/registrationParentFolder';
 import { JsonConfig, Settings } from 'platform/desktop/constants';
 
-// eslint-disable-next-line import/no-cycle
 import {
   getValidatedProjectDir, loadJsonConfig, saveConfig,
 } from './common';

client/platform/desktop/backend/native/common.spec.ts

@@ -129,7 +129,6 @@ vi.mock('./mediaJobs', () => ({
   } as DesktopJob)),
 }));
 // https://github.com/tschaub/mock-fs/issues/234
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
 const console = new Console(process.stdout, process.stderr);
 
 const emptyCsvString = '# comment line\n# metadata,fps: 32,"whatever"\n#comment line';
@@ -449,10 +448,8 @@ beforeEach(() => {
       },
     },
     '/home/user/viamedata': {
-    // eslint-disable-next-line @typescript-eslint/naming-convention
       DIVE_Jobs: {
         goodTrainingJob: {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
           category_models: {
             'detector.pipe': '',
             'trained_detector.zip': '',
@@ -462,17 +459,14 @@ beforeEach(() => {
           missingModelFolder: {},
         },
         missingPipeTrainingJob: {
-        // eslint-disable-next-line @typescript-eslint/naming-convention
           category_models: {
             'trained_detector.zip': '',
           },
         },
       },
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       DIVE_Pipelines: {
       /* Empty */
       },
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       DIVE_Projects: {
         projectid1: {
           'meta.json': JSON.stringify({
@@ -817,15 +811,13 @@ beforeEach(() => {
               'bar.png',
             ],
             attributes: {
-            // eslint-disable-next-line @typescript-eslint/naming-convention
               track_attribute1: {
                 belongs: 'track',
                 datatype: 'text',
                 values: ['value1', 'value2', 'value3'],
                 name: 'attribute1',
                 key: 'track_attribute1',
               },
-              // eslint-disable-next-line @typescript-eslint/naming-convention
               detection_attribute1: {
                 belongs: 'detection',
                 datatype: 'number',

client/platform/desktop/backend/native/common.ts

@@ -42,7 +42,6 @@ import * as dive from 'platform/desktop/backend/serializers/dive';
 import * as coco from 'platform/desktop/backend/serializers/coco';
 import kpf from 'platform/desktop/backend/serializers/kpf';
 // TODO:  Check to Refactor this
-// eslint-disable-next-line import/no-cycle
 import { checkMedia } from 'platform/desktop/backend/native/mediaJobs';
 import {
   websafeImageTypes, websafeVideoTypes, otherImageTypes, otherVideoTypes, fileVideoTypes,
@@ -63,7 +62,6 @@ import { parseFrameTimestamp } from 'dive-common/frameTimestamp';
 import processTrackAttributes from './attributeProcessor';
 import { upgrade } from './migrations';
 // TODO:  Check to Refactor this
-// eslint-disable-next-line import/no-cycle
 import { getMultiCamUrls, transcodeMultiCam } from './multiCamUtils';
 import {
   loadRegistrationFiles, referenceCameraName, saveRegistrationToDatasetDir,
@@ -966,7 +964,7 @@ async function autodiscoverData(settings: Settings): Promise<JsonConfig[]> {
   const dspath = npath.join(settings.dataPath, ProjectsFolderName);
   const dsids = await fs.readdir(dspath);
   const metas: JsonConfig[] = [];
-  /* eslint-disable no-await-in-loop,no-continue */
+  /* eslint-disable no-await-in-loop */
   for (let i = 0; i < dsids.length; i += 1) {
     const datasetId = dsids[i];
     try {

client/platform/desktop/backend/native/datasetCalibration.ts

@@ -15,7 +15,6 @@ import parseStereoCalibrationJson from 'dive-common/utils/parseStereoCalibration
 import { Settings, LastCalibrationBaseName } from 'platform/desktop/constants';
 
 import { prepareDatasetCalibration } from './calibrationConvert';
-// eslint-disable-next-line import/no-cycle
 import {
   autodiscoverData, getValidatedProjectDir, loadJsonConfig, saveProjectConfig,
 } from './common';

client/platform/desktop/backend/native/mediaJobs.ts

@@ -15,7 +15,6 @@ import {
   jobFileEchoMiddleware, spawnResult, createWorkingDirectory, getBinaryPath,
 } from './utils';
 // TODO:  Check to Refactor this
-// eslint-disable-next-line import/no-cycle
 import {
   getTranscodedMultiCamType,
 } from './multiCamUtils';
@@ -259,7 +258,6 @@ async function convertMedia(
         endTime: new Date(),
       });
       // Update meta to reflect error
-      // eslint-disable-next-line no-param-reassign
       onFail?.(jobKey, args.meta, `Transcoding job failed with exit code ${code}`);
     } else {
       if (args.meta.type === 'video' || multiType === 'video') {

client/platform/desktop/backend/native/multiCamUtils.ts

@@ -7,7 +7,6 @@ import {
 } from 'dive-common/apispec';
 
 import { JsonConfig, Settings } from 'platform/desktop/constants';
-// eslint-disable-next-line import/no-cycle
 import { loadAnnotationFile, loadJsonConfig, getValidatedProjectDir } from 'platform/desktop/backend/native/common';
 import { serialize } from 'platform/desktop/backend/serializers/viame';
 import { parseFrameTimestamp } from 'dive-common/frameTimestamp';
@@ -34,7 +33,6 @@ function transcodeMultiCam(
 
         if (cameraData.type === 'image-sequence') {
           if (!cameraData.transcodedImageFiles) {
-          // eslint-disable-next-line no-param-reassign
             cameraData.transcodedImageFiles = [];
           }
           if (cameraData.originalImageFiles.includes(npath.basename(item))) {
@@ -45,7 +43,6 @@ function transcodeMultiCam(
         } else if (cameraData.type === 'video') {
           if (item === npath.join(cameraData.originalBasePath, cameraData.originalVideoFile)) {
             destLoc = destLoc.replace(cameraData.originalBasePath, `${projectDirAbsPath}/${cameraName}`);
-            // eslint-disable-next-line no-param-reassign
             cameraData.transcodedVideoFile = npath.basename(destLoc);
             break;
           }

client/platform/desktop/backend/native/multicamExport.spec.ts

@@ -102,7 +102,6 @@ beforeEach(() => {
       right: { 'img_right.png': '' },
     },
     '/home/user/viamedata': {
-      // eslint-disable-next-line @typescript-eslint/naming-convention
       DIVE_Projects: {
         multicamExport: {
           'meta.json': JSON.stringify({

client/platform/desktop/backend/native/multicamExport.ts

@@ -18,7 +18,6 @@ import {
 import * as viameSerializers from 'platform/desktop/backend/serializers/viame';
 import * as dive from 'platform/desktop/backend/serializers/dive';
 
-// eslint-disable-next-line import/no-cycle
 import {
   ArchiveMetadataFolderName, getValidatedProjectDir, loadAnnotationFile, loadJsonConfig,
 } from './common';

client/platform/desktop/backend/native/viame.ts

@@ -360,7 +360,6 @@ async function runPipeline(
 
   let multiOutFiles: Record<string, string>;
   if (meta.multiCam && stereoOrMultiCam) {
-    // eslint-disable-next-line max-len
     const { argFilePair, outFiles } = await writeMultiCamStereoPipelineArgs(jobWorkDir, meta, settings, requiresInput);
     Object.entries(argFilePair).forEach(([arg, file]) => {
       command.push(`-s ${arg}="${file}"`);

client/platform/desktop/backend/serializers/viame.spec.ts

@@ -182,12 +182,10 @@ const meta = {
 } as JsonConfig;
 const testFiles: Record<string, string> = { };
 testData.forEach((item, index) => {
-  // eslint-disable-next-line prefer-destructuring
   testFiles[`${index}.csv`] = item[0].join('\n');
 });
 const imageOrderFiles: Record<string, string> = { };
 imageFilenameTests.forEach((item, index) => {
-  // eslint-disable-next-line prefer-destructuring
   imageOrderFiles[`${index}.csv`] = item.csv.join('\n');
 });
 
@@ -242,7 +240,6 @@ describe('VIAME Python Compatibility Check', () => {
       // eslint-disable-next-line no-await-in-loop
       const results = await parse(csvStream);
       expect(Object.values(results[0].tracks)).toEqual(trackArray);
-      // eslint-disable-next-line no-await-in-loop
       const attData = processTrackAttributes(Object.values(results[0].tracks));
       expect(testAttributes).toEqual(attData.attributes);
     }

client/platform/desktop/backend/serializers/viame.ts

@@ -1,4 +1,3 @@
-/* eslint-disable max-len */
 /**
  * VIAME CSV parser/serializer copied logically from
  * dive_utils.serializers.viame python module

client/platform/desktop/backend/server.ts

@@ -354,7 +354,6 @@ apirouter.get('/media', (req, res, next) => {
   }
 
   const range = ranges[0];
-  // eslint-disable-next-line no-param-reassign
   res.status(206);
   res.setHeader('Content-Length', range.end - range.start + 1);
   res.setHeader('Content-Range', `bytes ${range.start}-${range.end}/${filestat.size}`);

client/platform/desktop/frontend/components/BulkImportDialog.vue

@@ -76,7 +76,6 @@ export default defineComponent({
       ctx.emit('finalize-import', finalImports);
     }
 
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
     function updateImportConfig(oldItem: DesktopMediaImportResponse, newItem: DesktopMediaImportResponse) {
       const itemIndex = imports.value.indexOf(oldItem);
 

client/platform/web-girder/api/dataset.service.spec.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-extraneous-dependencies -- Vitest is only used in tests
 import {
   beforeEach, describe, expect, it, vi,
 } from 'vitest';

client/platform/web-girder/api/frameMetadata.service.spec.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-extraneous-dependencies -- Vitest is only used in tests
 import {
   beforeEach, describe, expect, it, vi,
 } from 'vitest';

client/platform/web-girder/api/multicamResolve.spec.ts

@@ -1,6 +1,5 @@
 // @vitest-environment jsdom
 
-// eslint-disable-next-line import/no-extraneous-dependencies -- Vitest is only used in tests
 import {
   beforeEach,
   describe,

client/platform/web-girder/multicamCalibration.spec.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-extraneous-dependencies -- Vitest is only used in tests
 import { describe, expect, it } from 'vitest';
 
 import {

client/platform/web-girder/multicamFileRegistry.spec.ts

@@ -1,4 +1,3 @@
-// eslint-disable-next-line import/no-extraneous-dependencies -- Vitest is only used in tests
 import {
   describe, expect, it, beforeEach, vi,
 } from 'vitest';

client/platform/web-girder/store/useConfig.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export -- singleton composable store */
 import { ref } from 'vue';
 
 import {

client/platform/web-girder/store/useJobs.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export -- singleton composable store */
 import Vue, { computed, ref } from 'vue';
 import { GirderJob } from '@girder/components/src';
 import { all } from '@girder/components/src/components/Job/status';

client/platform/web-girder/store/useLocation.ts

@@ -1,4 +1,3 @@
-/* eslint-disable import/prefer-default-export -- singleton composable store */
 import type { GirderModel } from '@girder/components/src';
 import { computed, ref } from 'vue';
 import type { Route } from 'vue-router';