Fix test file download link#3726
Merged
williamjallen merged 1 commit intoMay 14, 2026
Merged
Conversation
josephsnyder
requested changes
May 14, 2026
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
The link still fails once the parameter has been replaced. There must have been something we were accounting for before with an explicit -1 in TestDetails.php.
cdash4simpletest=# select * from testmeasurement where testid=413;
id | name | type | value | testid
-----+-------------------+----------------+------------------------------+--------
311 | Processors | numeric/double | 1 | 413
312 | Environment | text/string | #CTEST_RESOURCE_GROUP_COUNT= | 413
313 | CTestConfig.cmake | file | | 413
(3 rows)
Fixes an issue introduced in Kitware#3662 which broke test file download links.
williamjallen
force-pushed
the
fix-test-file-download-link
branch
from
6c32ec8 to
dcecc57
Compare
Collaborator
Author
|
Oops, I just so happened to try with ID=1 which masked the fact that the |
josephsnyder
approved these changes
May 14, 2026
Member
josephsnyder
left a comment
josephsnyder
left a comment
There was a problem hiding this comment.
Thanks for the fix. Looks good now!
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue introduced in #3662 which broke test file download links.