Skip to content

Add new backfaceColor argument to appearance stdlib fn - #14693

Open
adamchalmers wants to merge 4 commits into
mainfrom
achalmers/customized-backfaces
Open

adamchalmers wants to merge 4 commits into
mainfrom
achalmers/customized-backfaces

Conversation

@adamchalmers

@adamchalmers adamchalmers commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Previously, if you set a surface's appearance, it would set the appearance of both the front face and backface. But users might want to visually distinguish front and backfaces.

So now they can use

appearance(color = "#ff0000", backfaceColor = "#112233")
Screenshot 2026-10-19 at 5 52 48 PM

Includes the Typescript codebase support so you can edit this in the modals

@adamchalmers
adamchalmers requested review from a team as code owners October 20, 2026 00:51
@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modeling-app Ready Ready Preview Oct 20, 2026 6:06pm UTC

Request Review

@codspeed

codspeed Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ 2 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

✅ 157 untouched benchmarks
⏩ 131 skipped benchmarks1


Comparing achalmers/customized-backfaces (04a29cd) with main (d3da241)2

Open in CodSpeed

Footnotes

  1. 131 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (252827e) during the generation of this report, so d3da241 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@adamchalmers
adamchalmers force-pushed the achalmers/customized-backfaces branch from 2c347bb to f640a8e Compare October 20, 2026 01:21
@adamchalmers
adamchalmers force-pushed the achalmers/customized-backfaces branch from fd4096c to 1f3eec5 Compare October 20, 2026 01:38
@adamchalmers adamchalmers changed the title KCL: Add new backfaceColor argument to appearance stdlib fn Add new backfaceColor argument to appearance stdlib fn Oct 20, 2026
Comment thread src/lib/operations.ts Outdated
Comment on lines 203 to +204
color: string
backfaceColor?: string

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for me: need to figure out why we need to override the types for string here as it should be automatic. This was the case for color already so it's not part of this PR.

Previously, if you set a surface's appearance, it would set the appearance
of both the front face _and_ backface. But users might want to visually
distinguish front and backfaces.

So now they can use
```
appearance(color = "#ff0000", backfaceColor = "#112233")
```

This branch was successfully deployed

1 active deployment
Preview — 04a29cd6 Deployed Oct 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants