Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Merging this PR will not alter performance
Comparing Footnotes
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop rebuilding models to open Settings, change scene preferences, or enter a sketch. Rust owns the active file and cache. Sketch operations reuse the loaded runtime; lint keeps context creation and Wasm restart calls in their lifecycle owners. Artificial waits and animations over 100 ms are blocked, and all new perf cases run in CI with a hard 150 ms budget.
Real-engine Rust and unmocked Playwright regressions cover unchanged sketch handoffs, invalid execution owners, file switching, reconnect, and actual Wasm crash recovery. The panic hook is compiled only into an isolated test build, never the normal app.
The backface regression is still red against the deployed engine: it caches the old material color. The engine fix is separate: KittyCAD/engine#5348, not another cache bust.
Hard-coded timings (before)
Results (before → animations; Settings → cache fix)
95/95 cases measured before/after animations. Settings adds the latest cache-fix measurement: 8/8 under 150 ms. Initial model load excluded. Other results remain the animation-only checkpoint (
a886a9102c). N/A = unsupported profile. Anything above 150 ms is absolutely insane and people will feel it.