Repository navigation
Add more fields to KCL execution responses - #1450
Open
adamchalmers wants to merge 6 commits into
Open
adamchalmers wants to merge 6 commits into
adamchalmers wants to merge 6 commits into
Conversation
adamchalmers
commented
Oct 14, 2026
| } | ||
| } | ||
|
|
||
| /// Region-creation algorithm version. |
Collaborator
Author
There was a problem hiding this comment.
Oops. Copypasta.
| ExecKclProject { | ||
| /// Result after executing KCL. | ||
| result: Result<crate::exec_kcl::ExecKclProjectOk, crate::exec_kcl::ExecKclProjectErr>, | ||
| result: Box<Result<crate::exec_kcl::ExecKclProjectOk, crate::exec_kcl::ExecKclProjectErr>>, |
Collaborator
Author
There was a problem hiding this comment.
Boxed this because we really are sending a lot of information in this response, it becomes very big. There's no need to worry about a single Box (heap pointer dereferencing) when we're sending all this data over the network.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1450 +/- ##
=======================================
Coverage ? 35.99%
=======================================
Files ? 32
Lines ? 1742
Branches ? 0
=======================================
Hits ? 627
Misses ? 1115
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
adamchalmers
force-pushed
the
achalmers/more-fields-kcl
branch
from
October 15, 2026 02:38
70f058b to
45807e3
Compare
adamchalmers
force-pushed
the
achalmers/more-fields-kcl
branch
from
October 15, 2026 02:54
b6ef12c to
3bea00e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of KittyCAD/modeling-app#14615
Depends on KittyCAD/modeling-app#14575